Function returns strings but not when stored in variable

Question

I have a strange problem with a function i wrote. When returning an hardcoded string like "Hello" it returns this value, but when i store this value in a variable it doesn't return anything.

Also when i don't store it in a variable and try to return it nothing gets returned.

Below is my code. Can anybody see what i'm doing wrong?

Thanks in advance.

 public function getPath($pageID = null) {
    if($pageID == null) $pageID = $this->id;

    $data = $this->_db->fetch_array("SELECT * FROM `pages` WHERE `id` = '".$pageID."'");

    if(!empty($data)) {
        $this->tempPath[] = $data['basename'];

        if($data['parentID'] != 0) {
            $this->getPath($data['parentID']);
        } else {
            $returnPath = $this->tempPath;
            $this->tempPath = array();
            $returnPath = implode('/', array_reverse($returnPath));
            //This variable holds the value, when echo'ed its the correct value
            echo $returnPath;

            return $returnPath;
        }
    }
}

Can't reproduce your problem. Do you get any errors? Do you show us your real code? — Rizier123
– Rizier123, Commented Oct 18, 2015 at 10:24
This is all the code used in the function, it's producing the correct data but when returning nothing gets returned. When i code: return "Hello" it does return "Hello", But it doesn't return any values in variables. — Jasper Vergers
– Jasper Vergers, Commented Oct 18, 2015 at 10:25
What is the exact output of: var_dump($returnPath); right before the return statement? — Rizier123
– Rizier123, Commented Oct 18, 2015 at 10:28
This is the ouput: string(15) "admin/dashboard" string(15) "admin/pages/add" string(11) "admin/pages" — Jasper Vergers
– Jasper Vergers, Commented Oct 18, 2015 at 10:30

Jasper Vergers · Accepted Answer · 2015-10-18 10:47:49Z

1

Rewrote the code to the following and now it's working

 public function getPath($pageID = null) {
    if($pageID == null) $pageID = $this->id;

    $data = $this->_db->fetch_array("SELECT * FROM `pages` WHERE `id` = '".$pageID."'");

    if(!empty($data)) {
        $this->tempPath[] = $data['basename'];
    }

    return implode('/', $this->tempPath);
}

Problem was that the code was in a foreach loop which kept overwriting the correct values and looping till there is no path to return. Thanks for the suggestions.

More code isn't always better :-)

answered Oct 18, 2015 at 10:47

Jasper Vergers

295 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Function returns strings but not when stored in variable

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related