Adding word objects in to an ArrayList

Question

import java.util.Scanner;
import java.util.ArrayList;
import java.io.File;

class Ordliste {

  ArrayList<String> list = new ArrayList<String>();

  public void lesBok(String filnavn) throws Exception {
    File fil = new File(filnavn);
    Scanner s = new Scanner(fil);

    while(s.hasNextLine()){
        leggTilOrd(s.nextLine());
    }
  }

  private void leggTilOrd(String ord){

    Ord w = new Ord(ord);
      if (list.contains(w)) {
          w.oekAntall();
      }
      else {
          list.add(w);
      }
    }

  }

    class Ord {

      private String tekst;
      private int verdi = hentAntall();

      public Ord(String tekst){
        this.tekst = tekst;
        this.verdi = verdi;
      } //Konstruktoer

      public String toString(){
        return tekst;
      }

  public int hentAntall(){
    return verdi;
  }

  public void oekAntall(){
    verdi++;
  }
}

What I am basically trying to do, is reading a words from a txt.file. The code is supposed to only save each word once, and add "verdi" 1 up each time it repeats.

What have I done wrong? "ordliste" and "ord" are two different java files. I hope you understand what I've been trying to do, even tho it's in Norwegian.

public class test{ public static void main (String[] args) throws Exception { Ordliste liste = new Ordliste(); liste.lesBok("scarlet.text"); } } — dank memes
– dank memes, Commented Oct 19, 2015 at 1:08
why not use String.split? Do you expect each word to be separated by a space,ie, ' '? — Fritz
– Fritz, Commented Oct 19, 2015 at 1:15
I forgot to say that the textfile replaced every space with linebreaks, there is just one word each line. I think my "leggTilOrd" method does not work the way I want it to. — dank memes
– dank memes, Commented Oct 19, 2015 at 1:20

HaveNoDisplayName · Accepted Answer · 2015-10-19 01:46:07Z

1

the code "list.contains(w)" in method leggTilOrd is not appropriate;

you are not charging the repeat word but the repeat Ord object.

so if you want to charge the repeat word, your object Ord should overwrite the equals method:

class Ord{

@Override
public boolean equals(Object obj) {
    Ord o = (Ord)obj;
    return tekst.equals(o.tekst);
}

private String tekst;
private int verdi = hentAntall();

public Ord(String tekst) {
    this.tekst = tekst;
    this.verdi = verdi;
} // Konstruktoer

public String toString() {
    return tekst;
}

public int hentAntall() {
    return verdi;
}

public void oekAntall() {
    verdi++;
}
}

edited Oct 19, 2015 at 1:46

HaveNoDisplayName

8,537106 gold badges41 silver badges50 bronze badges

answered Oct 19, 2015 at 1:32

Xuehong.wu

312 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

dank memes Over a year ago

Is it possible to do this inside the leggTilOrd method? Because I am not really supposed to change the Ord class.

Xuehong.wu Over a year ago

I am sorry, i just didn't see the code clearly, your list is declared ArrayList<String> not ArrayList<Ord>. So if you just want to save non-repeated words in list：use list.contains(ord) not list.contains(w) in leggTilOrd method is ok. But i am confused that how do you handler the Ord objects?

Collectives™ on Stack Overflow

Adding word objects in to an ArrayList

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related