onclick window.open not passing php variable

Question

When using the following, I click on the submit button and it opens "domain.com/bhl.php?search=" and not passing the $_GET variable like I need.

<form action="bhl.php" method="GET">
    <input name="search" type="text" placeholder="Type here">
    <input type="submit" onclick="window.open('bhl.php?search=<?php echo $_GET['search'] ?>','targetWindow','toolbar=no, location=no, status=no, menubar=no, scrollbars=yes, resizable=yes, width=700, height=500'); return false;" />
</form>

Note that you are using quotation marks in a weird way. Just opening a bunch of them won't work as intended (since it will look like you are closing it). — FirstOne
– FirstOne, Commented Oct 21, 2015 at 18:14
@FirstOne There are no issue with quotation marks in that code. — epascarello
– epascarello, Commented Oct 21, 2015 at 18:17
@epascarello I might be mistaken, but I think I saw onclick='window.open('b.... Is it possible that a quick edition happened without showing the edit? Anyway, sorry about that, my bad... — FirstOne
– FirstOne, Commented Oct 21, 2015 at 18:21

epascarello · Accepted Answer · 2015-10-21 18:15:19Z

2

It does not work because you are reading the value of the search parameter when the page has originally loaded. PHP does not run after the page load. You would need to set the value with JavaScript when the button is clicked.

<input type="submit" onclick="window.open('bhl.php?search=' + encodeURIComponent(this.form.search.value),'targetWindow','toolbar=no, location=no, status=no, menubar=no, scrollbars=yes, resizable=yes, width=700, height=500'); return false;" />

edited Oct 21, 2015 at 18:15

answered Oct 21, 2015 at 18:13

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pharm · Accepted Answer · 2015-10-21 18:18:57Z

0

You cannot pass a PHP variable through since theres no value when the page loads.

Try sending the value with javascript:

<form action="bhl.php" method="GET">
    <input id="search" type="text" placeholder="Type here">
    <input type="submit" onclick="window.open('bhl.php?search='+document.getElementById('search').value,'targetWindow','toolbar=no, location=no, status=no, menubar=no, scrollbars=yes, resizable=yes, width=700, height=500'); return false;" />
</form>

Although I'd define a function then just call that function, rather than using inline javascript.

answered Oct 21, 2015 at 18:18

Pharm

1621 silver badge13 bronze badges

Collectives™ on Stack Overflow

onclick window.open not passing php variable

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related