counter in a php recursive function

Question

I've looked thru the questions already with the system, but couldn't find the answer to my problem. I want to try a counter in a php recursive function, which looks for and deletes empty folders. I paste below a way to echo non-empties as "–" and empties as "|". It looks ok after all, but in case there's a lot to purge, it all grows into gibberish on the screen. Instead I'd like to see the numbers of folders checked vs deleted. Here's the code compiled so far using StackOverflow too. Any help pls?

function RemoveEmptySubFolders($path) {
    echo "–";
    $empty = true;
    foreach ( glob ( $path . DIRECTORY_SEPARATOR . "*" ) as $file ) {
        if (is_dir ( $file )) {
            if (! RemoveEmptySubFolders ( $file ))
                $empty = false;
        } else {
            $empty = false;
        }
    }
    if ($empty) {
        if (is_dir ( $path )) {
        // echo "Removing $path...<br>";
        rmdir ( $path );
        echo "|";
        }
    }
    return $empty;
}

You can probably use references in your function : function RemoveEmptySubFolders($path, &$cnt) : php.net/manual/en/language.references.pass.php — Steven
– Steven, Commented Oct 22, 2015 at 6:27
Do you want to see the total sum of all deleted vs empty or only the ones by the actual recursion? — inetphantom
– inetphantom, Commented Oct 22, 2015 at 6:49
So please accept the answer which solved your problem. Look at the tour(stackoverflow.com/tour) for the use of SO — inetphantom
– inetphantom, Commented Oct 22, 2015 at 12:09

Amarnasan · Accepted Answer · 2015-10-22 06:37:11Z

4

Just pass the variables as reference:

function recursive($path, &$directories, &$removed) {
    echo "-";
    $directories ++;
    $empty = true;
    foreach ( glob ( $path . DIRECTORY_SEPARATOR . "*" ) as $file ) {
        if (is_dir ( $file )) {
            if (! recursive ( $file, $directories, $removed ))
                $empty = false;
        } else {
            $empty = false;
        }
    }
    if ($empty) {
        if (is_dir ( $path )) {
            $removed++;
            echo "|";
        }
    }
    return $empty;
}

$path = "c:\exampledir";
$directories = 0;
$removed = 0;
recursive($path, $directories, $removed);
echo("<br>$directories, $removed");

You could also use global variables, but that's very ugly, and every time you use a global variable othen than the standard ones, a kitty dies.

answered Oct 22, 2015 at 6:37

Amarnasan

15.7k7 gold badges35 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

inetphantom Over a year ago

Vote up for the kitties!

KirKu Over a year ago

Thanx man, it works now! My mistake was failing to pass along with the function itself the incremented vars in 'if (! recursive ( $file, $directories, $removed ))'.

KirKu Over a year ago

Now inspired I've added &$dash_count for fun: $dash_count++; if($dash_count > 70) { echo "–<br>"; $dash_count = 0; } else echo "–";

inetphantom · Accepted Answer · 2015-10-22 12:43:12Z

0

Object-Oriented variant:

Put everything in a class and add the instance attributes $checked and $deleted, then increment them with a selfmade procedure or (nasty code) just with += 1 or $var ++.

answered Oct 22, 2015 at 12:43

inetphantom

2,5474 gold badges44 silver badges65 bronze badges

Collectives™ on Stack Overflow

counter in a php recursive function

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related