Undefined variable passing data using service

Question

I have declared my app and have one controller (for demonstration purposes):

    var module = angular.module("app", [])


    module.controller("modalCtrl", ["$scope", function ($scope, dataService) {


    $scope.printEntity = function () {
         console.log(dataService.getEntityArray());
    }

}]);

And a service:

module.factory("dataService", function () {

var entityArrayService = [1,2];

return {

    getEntityArray: function () {
        return entityArrayService;
    }

};

});

When I call $scope.printEntity from my view, I'm always told dataService.getEntityArray() is undefined.

I've loaded the service as a dependency and declared my entityArrayService array outside of my return statement. I've looked high and low for an answer but to no avail. My goal is to share a piece of data between two controllers, but at the minute I can't even use one controller to retrieve data.

br3w5 · Accepted Answer · 2015-10-22 13:01:09Z

1

The service isn't loaded as a dependency. Change this line:

module.controller("modalCtrl", ["$scope", function ($scope, dataService) {

to this:

module.controller("modalCtrl", ["$scope", "dataService", function ($scope, dataService) {

answered Oct 22, 2015 at 13:01

br3w5

4,6336 gold badges35 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Magus · Accepted Answer · 2015-10-22 13:01:16Z

0

You are using strict syntax for dependencies declaration. So if you add a parameter to your controller, you must add its declaration too.

module.controller("modalCtrl", ["$scope", "dataService", function ($scope, dataService) { 
    ... 
}

answered Oct 22, 2015 at 13:01

Magus

15.1k4 gold badges40 silver badges52 bronze badges

Comments

hsz · Accepted Answer · 2015-10-22 13:01:19Z

0

You didn't inject dataService in your controller. Try with:

module.controller("modalCtrl", ["$scope", "dataService", function ($scope, dataService) {
  // ...
});

answered Oct 22, 2015 at 13:01

hsz

153k63 gold badges268 silver badges320 bronze badges

Comments

morels · Accepted Answer · 2015-10-22 13:29:43Z

0

The injection of the service in the controller is missing:

please correct to:

...
module.controller("modalCtrl", ["$scope", "dataService", function ($scope, dataService) {
...

The other code is correct.

answered Oct 22, 2015 at 13:29

morels

2,11520 silver badges24 bronze badges

Collectives™ on Stack Overflow

Undefined variable passing data using service

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related