Splitting String into characters and matching with users input in Java

Question

I am working on very simple program to split characters from the word and ask user to input character. IF user input character match the characters array then display "YES" if not then display "NO". I used .ToCharArray method and loop to split each character from word and assign it to character array. Then I used for loop with IF statement to check the condition and display the result. But it matches with only one character from character array and ignores other.

public class test {


public static void main(String[] args) {

    // Declaring variables
    String[] wordsList= {"java"};
    char[] wChar = wordsList[0].toCharArray();
    char wCharLetter = 0;
    char inputChar;

    Scanner input = new Scanner (System.in);

    for (int i = 0; i < wordsList[0].length(); i++){
        wCharLetter = wChar[i];
    }

    for (int i = 0; i < wordsList[0].length(); i++){
        inputChar = input.next().charAt(0);
        if (inputChar==wCharLetter){
            System.out.println("YES");
        }
        else{
            System.out.println("NO");
        }
    }       

} }

According to my understanding; technically the wCharLetter variable should store all the characters, and it does when I print wCharLetter but doesn't work in matching.

The wCharLetter variable only stores the last character, because with each assignment you are overwriting the previous value. — Marvin
– Marvin, Commented Oct 29, 2015 at 17:19
In what way do you think one letter the same as multiple letters? — Elliott Frisch
– Elliott Frisch, Commented Oct 29, 2015 at 17:25

Mena · Accepted Answer · 2015-10-29 17:24:00Z

1

Simply assign wCharLetter = wChar[i]; within your second for loop and ditch the previous loop:

for (int i = 0; i < wordsList[0].length(); i++) {
    wCharLetter = wChar[i];
    inputChar = input.next().charAt(0);
    if (inputChar == wCharLetter) {
        System.out.println("YES");
    } else {
        System.out.println("NO");
    }
}

Also, don't forget to close your Scanner once done.

// ...
input.close();

Possible input/outputs:

j
YES
a
YES
v
YES
a
YES

... or...

l
NO
a
YES
v
YES
a
YES

answered Oct 29, 2015 at 17:24

Mena

48.6k11 gold badges90 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Maihan Nijat Over a year ago

It works when characters are entered in the same order of word characters. j a v a (works) but if enter: a v j a (doesn't work then). Thanks for help

Mena Over a year ago

@MaihanNijat yes that's normal. If you want it to work regardless of order, you'll need to ditch that code pretty much entirely and collect the characters in one list, then the input in another, then compare the two lists. You'll also need a breaking case for when the user is supposed to stop adding characters.

Simadri · Accepted Answer · 2015-10-29 17:55:41Z

0

Check this out:

String wordArray="Java";

    Scanner input = new Scanner (System.in);



        for (int i=0;i<=wordArray.length();i++)
        {
            if(wordArray.charAt(i)==input.next().charAt(0))
            {
                System.out.println("YES");
                break;
            }
            else
            {
                System.out.println("NO");
                break;
            }
        }

    input.close();

Hope this will help.

answered Oct 29, 2015 at 17:55

Simadri

112 bronze badges

Collectives™ on Stack Overflow

Splitting String into characters and matching with users input in Java

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related