Save SQL result in php function as array

Question

so I am basically trying to take the quote_author and quote_text results from SQL through a php function and then display it in stylized html. When I call the function I want to get 2 variables $quote_text and $quote_author, so I can put them in two separe divs in html, because they are stylized differently.

This is my code

function get_quotes(){

$connection = mysqli_connect("localhost","xxx","xxx","xxx");
$sql = "SELECT quote_text, quote_author FROM quotes ORDER BY rand() LIMIT 1";
$result = mysqli_query($connection,$sql);
while($row = mysqli_fetch_assoc($result)) {
       //how can I get the two results $row['quote_text'] and $row['quote_author'] 
       //out of the function
   }
}

get_quotes();
echo $row['quote_text'];
echo $row['quote_author'];

Thanks in advance!

return ['text' => $row['quote_text'], 'author' => $row['quote_author']] — samayo
– samayo, Commented Oct 29, 2015 at 18:01
Why do you need a while loop if you limit the query to one result? — Barmar
– Barmar, Commented Oct 29, 2015 at 18:03

Barmar · Accepted Answer · 2015-10-29 18:07:02Z

1

You should use a return statement to return the results from the function. You also don't need a while loop, since the query only returns one row.

$row = mysqli_fetch_assoc();
return $row;

Then the caller does:

$row = get_quotes();
if ($row) {
    echo $row['quote_text'];
    echo $row['quote_author'];
}

answered Oct 29, 2015 at 18:07

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tsvetilin Boynovski Over a year ago

Thanks dude! You are awesome.

Piyin · Accepted Answer · 2015-10-29 18:09:37Z

1

You should do something like:

function get_quotes(){
    $connection = mysqli_connect("localhost","xxx","xxx","xxx");
    $sql = "SELECT quote_text, quote_author FROM quotes ORDER BY rand() LIMIT 1";
    $result = mysqli_query($connection,$sql);
    return mysqli_fetch_assoc($result);
}

$row = get_quotes();
echo $row['quote_text'];
echo $row['quote_author'];

answered Oct 29, 2015 at 18:09

Piyin

1,8341 gold badge18 silver badges24 bronze badges

2 Comments

Robert Wilson Over a year ago

won't you check if $row isn't null before accessing it's indices?

Piyin Over a year ago

@ciriusrob Sure, but it wasn't a requirement. I'd also check for connection errors.

Collectives™ on Stack Overflow

Save SQL result in php function as array

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related