Foreach loop syntax error

Question

I have this piece of code:

private V[] elements;

public int size(){
  int returnValue = 0;
  for(TableEntry<K,V> pointer :  elements){
    while(pointer != null){
      returnValue++;
      pointer = pointer.next;
    }
  }
  return returnValue;
}

And I get error:

Type mismatch: cannot convert from element type V to SimpleHashtable.TableEntry in foreach line.

Here is complete class: Code

elements is an array of V, not an array of TableEntry<K, V>... — assylias
– assylias, Commented Oct 30, 2015 at 7:38
Your problem is not about the for loop, but about how you mix and cast between V and TableEntry in your code. You need to choose one or the other... — assylias
– assylias, Commented Oct 30, 2015 at 7:41

Tomas · Accepted Answer · 2015-10-30 07:43:55Z

4

You are trying to get TableEntry objects from an array of V (elements). This will not work.

Also, your loop is double, for each entry in the array you try to search through the rest of the array.

Try this instead:

public int size() {
    int returnValue = 0;
    for (V pointer : elements)
        if (pointer != null) {
            returnValue++;
        }
    return returnValue;
}

answered Oct 30, 2015 at 7:43

Tomas

1,32310 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mustafa sabir · Accepted Answer · 2015-10-30 17:07:44Z

0

Change the type of pointer variable to V.

for (V pointer : elements) {
    \\ loop body
}

edited Oct 30, 2015 at 17:07

user3453226

answered Oct 30, 2015 at 7:46

Mustafa sabir

4,3801 gold badge23 silver badges30 bronze badges

1 Comment

Tomas Over a year ago

V doesn't have to implement Iterable, he is iterating over an array not over V. See JLS 14.14.2.

Collectives™ on Stack Overflow

Foreach loop syntax error

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related