I am getting an syntax error when using expr

Question

Here is the code:

#!/bin/bash
reg='[0-9]{1}-[0-9]{2}-[0-9]{6}-[0-9Xx]{1}'
while read ISBN; do
    if [[ $ISBN =~ '$$$' ]]; then
        exit 0
    else
        if [[ $ISBN =~ $reg ]]; then
            ISBN=${ISBN//-/}
            let sum=0
            let k=11
            for index in `seq 1 10`; do
                array[$index]=`echo $ISBN | cut -c"$index"`
                k=$(expr $k - $index)
                n=$(expr $k * ${array[$index]})
                sum=$(expr $sum + $n)
                echo $sum
            done
            #do something
        else
            echo Invaild
        fi
    fi
done

My input:

0-00-000001-1

The error:

expr: syntax error
expr: syntax error

but when I run expr in terminal like following:

k=11
index=1
echo $(expr $k - $index)

it works well.Can you tell me why?

You don't need to use expr at all; use arithmetic expansion: k=$(($k - $index)). — chepner
– chepner, Commented Oct 31, 2015 at 16:20
Use for ((index=0; index < 10; index++)) for the for loop and ${ISBN:$index:1} in place of the cut pipeline. — chepner
– chepner, Commented Oct 31, 2015 at 16:22

chepner · Accepted Answer · 2015-10-31 16:26:38Z

4

With expr, you need to escape the * to avoid it being expanded as a file glob:

n=$(expr $k \* ${array[$index]})

With arithmetic expressions, this is not an issue:

n=$(( $k * ${array[$index]} ))

answered Oct 31, 2015 at 16:26

chepner

538k77 gold badges594 silver badges746 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

I am getting an syntax error when using expr

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related