PHP variables inside HTML Code

Question

I am making a student sign-up form using html and php.

First you are asked to insert your name, password and email and when you click submit, it takes you to another page (ChooseDepartment.php) in which you get a list of all departments from my database to choose your own.

Now, I am a total newbie, so here is the part of my php code that I am stuck with in ChooseDepartment.php:

$ShowPossibleDep = mysql_query("SELECT NAME,DEPT_ID FROM DEPARTMENT");
if(mysql_num_rows($ShowPossibleDep) > 0){
    echo "<br />"."Available departments: "."  ".mysql_num_rows($ShowPossibleDep)."<br />";
    echo "<br />";
    echo '<form id = "dept" action = "Courses.php" method = "post">';
    while($row = mysql_fetch_array($ShowPossibleDep))
    {
        echo $row['NAME'];
        echo '<input type="radio" name="department" value=<?php $row['DEPT_ID'] ?>>';
        echo "<br />";


    }
    echo '<input type = "submit" value = "Submit" id = "submitDepartment">';
    echo </form>;

}

I am trying to make the value of the radio button carry the value of the the department id so I can then update my database with the student's department which is currently NULL, but I can't figure out how to use both html and php at the very same line correctly! This gives me syntax error!

I strongly believe you should read PHP in w3school first before start using SO. No pun intended. — Imdad
– Imdad, Commented Oct 31, 2015 at 20:11
I'm voting to close this question as off-topic because It is of very very low quality. It seems students as asking question to teacher in about basic syntax of a programming language — Imdad
– Imdad, Commented Oct 31, 2015 at 20:15
@Imdad: I think we should leave it open, as we all start from asking low quality questions. :) — Mubin
– Mubin, Commented Oct 31, 2015 at 20:20

Mubin · Accepted Answer · 2015-10-31 19:56:16Z

as you're in PHP, so you don't need to open and close PHP tag.

The reason you're getting Syntax error is just because you're not manipulating string properly.

error is with this line

echo '<input type="radio" name="department" value=<?php $row['DEPT_ID'] ?>>';              
                                                   ^ here                ^ here

So you need to remove the PHP tags and need to concatenate string properly like:

echo '<input type="radio" name="department" value="'.$row['DEPT_ID']. '">';

and with this one

echo </form>;

you're missing quotes around form tag. So it should be,

echo '</form>';

There are some other typos are as well, so your final code will be look like this.

$ShowPossibleDep = mysql_query("SELECT NAME,DEPT_ID FROM DEPARTMENT");
if(mysql_num_rows($ShowPossibleDep) > 0){
    echo "<br />Available departments: ".mysql_num_rows($ShowPossibleDep);
    //echo "<br />";  add this <br /> tag to next echo
    echo '<br /><form id = "dept" action = "Courses.php" method = "post">';
    while($row = mysql_fetch_array($ShowPossibleDep))
    {
        echo $row['NAME'];
        echo '<input type="radio" name="department" value=" '.$row['DEPT_ID'].'"><br />';
        //or you can do this way
        //echo "<input type='radio' name='department' value='$row[DEPT_ID]'><br />";
        //echo "<br />"; appended in upper statement.
    }
    echo '<input type = "submit" value = "Submit" id = "submitDepartment"></form>';
    //echo </form>;    closed already(above statement).

}

and without comments, more cleaner :)

$ShowPossibleDep = mysql_query("SELECT NAME,DEPT_ID FROM DEPARTMENT");
if(mysql_num_rows($ShowPossibleDep) > 0){
    echo "<br />Available departments: ".mysql_num_rows($ShowPossibleDep);
    echo '<br /><form id = "dept" action = "Courses.php" method = "post">';
    while($row = mysql_fetch_array($ShowPossibleDep))
    {
        echo $row['NAME'];
        echo '<input type="radio" name="department" value=" '.$row['DEPT_ID'].'"><br />';
    }
    echo '<input type = "submit" value = "Submit" id = "submitDepartment"></form>';
}

Vincent · Accepted Answer · 2015-10-31 19:35:14Z

0

Take a look at string operators

http://php.net/manual/en/language.operators.string.php

You can combine two strings in php with a dot, so that part of your code would become this:

    {
        echo $row['NAME'];
        echo '<input type="radio" name="department" value="'.$row['DEPT_ID'].'">';
        echo "<br />";
    }

answered Oct 31, 2015 at 19:35

Vincent

3481 silver badge9 bronze badges

Comments

Mateo Barahona · Accepted Answer · 2015-10-31 19:36:26Z

0

No need to open php tag again

$ShowPossibleDep = mysql_query("SELECT NAME,DEPT_ID FROM DEPARTMENT");
if(mysql_num_rows($ShowPossibleDep) > 0) {
    echo "<br />"."Available departments: "."   ".mysql_num_rows($ShowPossibleDep)."<br />";
    echo "<br />";
    echo '<form id = "dept" action = "Courses.php" method = "post">';
    while ($row = mysql_fetch_array($ShowPossibleDep)) {
        echo $row['NAME'];
        echo '<input type="radio" name="department" value="' . $row['DEPT_ID'] .'">';
        echo "<br />";

    }
    echo '<input type = "submit" value = "Submit" id = "submitDepartment">';
    echo "</form>";
}

edited Oct 31, 2015 at 19:36

answered Oct 31, 2015 at 19:32

Mateo Barahona

1,3918 silver badges11 bronze badges

Collectives™ on Stack Overflow

PHP variables inside HTML Code

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related