C# Insert Record into Database table

Question

I have a database that contains a Customer table with the following columns : CustID, CustName, ICNumber, ContactNumber and Address. It is a service-based database.

string localdb = ConfigurationManager.ConnectionStrings["DatabaseConnectionString"].ConnectionString;

SqlConnection con = new SqlConnection(localdb);
con.Open();
SqlCommand cmd = new SqlCommand("INSERT INTO Customer(CustID,CustName,ICNumber,ContactNumber,Address)values(@CustID,@CustName,@ICNumber,@ContactNumber,@Address)", con);

                        cmd.Parameters.AddWithValue("@CustID", txtCustID.Text);
                        cmd.Parameters.AddWithValue("@CustName", txtCustName.Text);
                        cmd.Parameters.AddWithValue("@ICNumber", txtICNum.Text);
                        cmd.Parameters.AddWithValue("@ContactNumber", txtContact.Text);
                        cmd.Parameters.AddWithValue("@Address", txtAddress.Text);
                        cmd.ExecuteNonQuery();
                        con.Close();

The code compiles and runs. The problem I am having is that the record is not added into the table after cmd.ExecuteNonQuery(); is called.

Why is the record not showing up in the database table?

What value does ExecuteNonQuery return? Also, you should wrap your SqlConnection and SqlCommand in using blocks. — Keith Rousseau
– Keith Rousseau, Commented Nov 2, 2015 at 12:44
Your code appears correct so this is most likely a database issue. Is your primary key for the table CustID? If it is you cannot enter it like you are trying to do. — Stephen Brickner
– Stephen Brickner, Commented Nov 2, 2015 at 12:45
Are you using a local database file? If so, are you certain you're looking in the right file? Your project config may be making a copy of the local DB file and inserting into that. — D Stanley
– D Stanley, Commented Nov 2, 2015 at 16:13

Felipe Oriani · Accepted Answer · 2015-11-02 12:46:00Z

1

You forgot to close the quotes " on the insert command. It is nice to use try/catch to avoid problems with your insert, for sample:

string localdb = ConfigurationManager.ConnectionStrings["DatabaseConnectionString"].ConnectionString;

try
{
    SqlConnection con = new SqlConnection(localdb))


    con.Open();

    SqlCommand cmd = new SqlCommand("INSERT INTO Customer(CustID, CustName, ICNumber, ContactNumber, Address) VALUES (@CustID, @CustName, @ICNumber, @ContactNumber, @Address)", con);
    cmd.Parameters.AddWithValue("@CustID", txtCustID.Text);
    cmd.Parameters.AddWithValue("@CustName", txtCustName.Text);
    cmd.Parameters.AddWithValue("@ICNumber", txtICNum.Text);
    cmd.Parameters.AddWithValue("@ContactNumber", txtContact.Text);
    cmd.Parameters.AddWithValue("@Address", txtAddress.Text);
    cmd.ExecuteNonQuery();
}
catch
{
    // some errors 
}
finally 
{
    if (con.State == ConnectionState.Open)
       con.Close();
}

answered Nov 2, 2015 at 12:46

Felipe Oriani

38.7k20 gold badges141 silver badges203 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sybren Over a year ago

Why not use an using statement?

Felipe Oriani Over a year ago

Yes, could be using statement, but what happen if the database server is out?

Collectives™ on Stack Overflow

C# Insert Record into Database table

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related