Create and fill combo box with mysql data with php

Question

I have done google searches and found several answers but I cannot get this to work. I am trying to read a field from ym mysql database and create and populate a combo box containing those values. The database connection works but all I get is a list of the values and no combo box. I am posting my code, along with the results.

<?php
$cn=mysql_connect("localhost","username","password") or die(mysql_error());
mysql_select_db("db_name",$cn) or die(mysql_error());
$sql = "SELECT LoadNumber FROM tblLoads";
$result = mysql_query($sql);
?>
<select name="loads" size=1>
<?
while($ri = mysql_fetch_array($result))
{
echo "<option value=" .$ri['LoadNumber'] . ">" . $ri['LoadNumber'] . "</option>";
}
echo "</select> "
?>

Here is my output:

Please, this is driving me crazy, i don't see what I am doing wrong. it does not create the combo box.

Can you check and provide your generated HTML? By glancing at your code I noticed that you're not wrapping $ri['LoadNumber']'s value in quotes, for example. — Paulo Avelar
– Paulo Avelar, Commented Nov 3, 2015 at 2:32
you didn't close this echo "</select> " and make sure short tags are enabled. Error reporting would have signaled that "syntax" error which is off-topic. — Funk Forty Niner
– Funk Forty Niner, Commented Nov 3, 2015 at 3:16
This question has been viewed over 2500 times, and noone can give me a positive vote? this was a good question. — Musicdad
– Musicdad, Commented Mar 28, 2017 at 22:20

Nimantha · Accepted Answer · 2021-10-29 16:05:42Z

2

You are complicating your code! Some part of it is wrapped in PHP and part of it is not.

Change this...

<select name="loads" size=1>
<?
while($ri = mysql_fetch_array($result))
{
echo "<option value=" .$ri['LoadNumber'] . ">" . $ri['LoadNumber'] . "</option>";
}
echo "</select> "
?>

To this...

<select name="loads" id="loads">
<?php while($ri = mysql_fetch_array($result)) { ?>
<option value="<?php echo $ri['LoadNumber'] ?>"><?php echo $ri['LoadNumber'] ?></option>
</select>
<?php } ?>

Finally... you should stop coding in mysql_ !!! It has been deprecated and will soon cease to exist. When that happens, all of your sites using mysql_ code will stop functioning.

You should really be learning pdo_mysql

edited Oct 29, 2021 at 16:05

Nimantha

6,5376 gold badges32 silver badges78 bronze badges

answered Nov 3, 2015 at 3:49

Kuya

7,3204 gold badges21 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Musicdad Over a year ago

thanks all. also figured out I had it in body, moved it to header and it worked somewhat.

kenphor · Accepted Answer · 2015-11-03 06:07:38Z

2

Try this.
<select name="loads" size=1>
<?php while($ri =  mysql_fetch_array($result))
{
echo "<option value=" .$ri['LoadNumber'] . ">" . $ri['LoadNumber'] . "</option>";?>
<select>

just move the last select from the php script.

edited Nov 3, 2015 at 6:07

answered Nov 3, 2015 at 5:40

kenphor

323 bronze badges

2 Comments

Abdulla Nilam Over a year ago

add that to your answer and delete from the comments

Errol Chaves Moya Over a year ago

This should have been the accepted answer: simple and more understandable than the accepted answer.

Collectives™ on Stack Overflow

Create and fill combo box with mysql data with php

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related