Cannot save record to database RAILS nested forms

Question

I cannot seem to save my record with nested forms.

This is what pry says:

pry(#<VenuesController>)> @venue.save
   (0.3ms)  begin transaction
  Tag Exists (0.2ms)  SELECT  1 AS one FROM "tags" WHERE ("tags"."name" = 'All ' AND "tags"."id" != 2) LIMIT 1
  Tag Exists (0.1ms)  SELECT  1 AS one FROM "tags" WHERE "tags"."name" = '' LIMIT 1
   (0.1ms)  rollback transaction
=> false

I thought I followed everything correctly. This is my nested form for tags

Tags:
    <%= f.collection_check_boxes :tag_ids, Tag.all, :id, :name %><br>

  Make a New Tag Here: <br>

   <%= f.fields_for :tags, Tag.new do |tag_field| %>
    <%= tag_field.label :name_tag %>
    <%= tag_field.text_field :name %>
    <% end %>

This is my venue model

class Venue < ActiveRecord::Base
  has_many :venue_tags
  has_many :tags, :through => :venue_tags

  accepts_nested_attributes_for :tags, allow_destroy: true
end

And my tag model

class Tag < ActiveRecord::Base
  has_many :venue_tags
  has_many :venues, :through => :venue_tags

  validates_uniqueness_of :name
end

However, when take off the 'validate uniqueness of name', I can save it, but new tags are added by itself.

And this is the pry log that tells it's true, but now I'm getting the correct tag added to the venue, but ALSO a new tag added to the venue (one I did not create myself). I am assuming this is happening because the New Tag Fields_for text was blank, which created a new tag by itself.

(0.2ms)  begin transaction
  SQL (0.6ms)  INSERT INTO "venues" ("name", "address", "discount", "latitude", "longitude", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?)  [["name", "SPICEBOX"], ["address", "33 Pell St, New York, NY 10013, United States"], ["discount", "10% OFF with Student ID"], ["latitude", 40.714831], ["longitude", -73.998628], ["created_at", "2015-11-03 06:12:52.400643"], ["updated_at", "2015-11-03 06:12:52.400643"]]
  SQL (0.2ms)  INSERT INTO "venue_tags" ("tag_id", "venue_id", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["tag_id", 2], ["venue_id", 11], ["created_at", "2015-11-03 06:12:52.404715"], ["updated_at", "2015-11-03 06:12:52.404715"]]
  SQL (0.2ms)  INSERT INTO "tags" ("name", "created_at", "updated_at") VALUES (?, ?, ?)  [["name", ""], ["created_at", "2015-11-03 06:12:52.408821"], ["updated_at", "2015-11-03 06:12:52.408821"]]
  SQL (0.1ms)  INSERT INTO "venue_tags" ("venue_id", "tag_id", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["venue_id", 11], ["tag_id", 9], ["created_at", "2015-11-03 06:12:52.411692"], ["updated_at", "2015-11-03 06:12:52.411692"]]
   (1.4ms)  commit transaction
=> true

Mark Swardstrom · Accepted Answer · 2015-11-03 06:44:40Z

1

You should probably add a validates :presence to tag name. You seem to have a tag in your db that has no name and when you add another with no name it is not unique and won't pass validations.

Take a look at the form or the strong parameters to see how that value is being cleared, if it is.

If it's blank because it was intentionally submitted that way, you can ignore it if blank.

accepts_nested_attributes_for :tags, allow_destroy: true, :reject_if => lambda { |a| a[:name].blank? }

answered Nov 3, 2015 at 6:44

Mark Swardstrom

18.3k6 gold badges74 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bryan Oemar · Accepted Answer · 2015-11-03 06:43:34Z

0

However, when take off the 'validate uniqueness of name', I can save it

Check the database for the name and see if it already exists. Since you are able to save the record, you code is probably ok.

To see why the record doesn't want to save, you can ask out the errors of the object you are trying to save. You can do this in your pry console.

@venue.save
...
=> false

@venue.errors.messages
=> ...

It will probably tell you that you already have a record with the same name. If that it's the case, then it would make sense your record isn't saving.

edited Nov 3, 2015 at 6:43

answered Nov 3, 2015 at 6:24

Bryan Oemar

9267 silver badges16 bronze badges

2 Comments

cats Over a year ago

Cool! I learned something new today, I didn't know you can do that. it does say this so you were right! pry(#<VenuesController>)> @venue.errors.messages => {:"tags.name"=>["has already been taken"]}

Bryan Oemar Over a year ago

@minlingzhao No problem at all :) . I assume you are new here? Please note that the preferred way of saying 'thanks' around here is by up-voting good questions and helpful answers, and by accepting the most helpful answer to any question you ask. Please see the About page and also How do I ask questions here? See you around :)

Collectives™ on Stack Overflow

Cannot save record to database RAILS nested forms

2 Answers 2

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related