PHP: Array translation problems

Question

This is my array:

$class = $row["class"];
 $classes = array( '1', '2', '4', '5', '6', '7', '8', '9', '10', '11'
    );
 $replacements = array( 'Warrior', 'Paladin', 'Hunter', 'Rogue',
   'Priest', 'Death Knight', 'Shaman', 'Mage', 'Warlock', 'Monk',
   'Druid' );
 $resultclass = str_replace( $classes, $replacements, $class );

My problem thou is that when i get the number 11 from the DB it displays "Warrior" twice and not "Druid"

How can i fix that?

What is in $class? Where is the DB at all? those are just arrays... — Ron Dadon
– Ron Dadon, Commented Nov 3, 2015 at 15:13
Not the best one, but if your classes will not become more, you can just switch the 1and the 11in your $classes array, so first it will replace 11 and later on 1 xD — swidmann
– swidmann, Commented Nov 3, 2015 at 15:13
And read the PHP Docs it has a big warning about str_replace Replacement order gotcha Because str_replace() replaces left to right, it might replace a previously inserted value when doing multiple replacements. See also the examples in this document. — Mark Baker
– Mark Baker, Commented Nov 3, 2015 at 15:14
Take a look at this question and answer - you can use preg_replace: stackoverflow.com/questions/9416175/… — Ron Dadon
– Ron Dadon, Commented Nov 3, 2015 at 15:18

M. Eriksson · Accepted Answer · 2015-11-03 15:14:19Z

5

Why not just do:

$replacements = array( 'Warrior', 'Paladin', 'Hunter', 'Rogue', 
   'Priest', 'Death Knight', 'Shaman', 'Mage', 'Warlock', 'Monk','Druid' );

$resultclass = $replacements[$row["class"] - 1];

answered Nov 3, 2015 at 15:14

M. Eriksson

13.7k4 gold badges31 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

swidmann Over a year ago

Due that the class number and the values are not associated, I think this is a good solution; I'll upvote this

M. Eriksson Over a year ago

Yepp. Looking at the question, it seems like he just wants to "translate" a number to a name and this would do just that. Using preg_replace or anything else seems over the top.

Noob · Accepted Answer · 2015-11-03 15:36:07Z

1

Why not do it like this, store it too a array and load it out of an array.

<?PHP
    $class = $row["class"];
    $classes = array( 
    '0' => 'Warrior' , '1' => 'Paladin' , '2' => 'Hunter' , '3' => 'Rogue', 
    '4' => 'Priest', '5' => 'Death Knight', '6' => 'Shaman',
    '7' => 'Mage', '8' => 'Warlock', '9' => 'Monk' ,'10' => 'Druid' ,
    );

     $resultclass = $classes[$class];
     ?>

answered Nov 3, 2015 at 15:36

Noob

1541 gold badge1 silver badge14 bronze badges

Comments

Laurentiu · Accepted Answer · 2015-11-03 15:19:25Z

0

Because "11" = "1"."1" all time will make replace for first match.

UPDATE

can use array_reverse:

    $class = "11";
 $classes = array_reverse(array( '1', '2', '4', '5', '6', '7', '8', '9', '10', '11'
    ));
 $replacements = array_reverse(array( 'Warrior', 'Paladin', 'Hunter', 'Rogue',
   'Priest', 'Death Knight', 'Shaman', 'Mage', 'Warlock', 'Monk',
   'Druid' ));
 $resultclass = str_replace( $classes, $replacements, $class );

var_dump($resultclass);

Now first match will start from big number to minimum, but be carefull if you have 12 that will take your 12th element not "1"."2"

edited Nov 3, 2015 at 15:19

answered Nov 3, 2015 at 15:14

Laurentiu

5846 silver badges27 bronze badges

Comments

Denis Brat · Accepted Answer · 2015-11-03 15:52:02Z

The way str_replace works is by iterating your $search array (first parameter) and replacing each found value by the value found at the same index in the $replace array (second argument). The precedence of the replacement are in the order the arrays are defined.

Now, when the function steps on your first search string '1', it finds two corresponding values at your string '11'. That's why you should be getting 'WarriorWarrior' instead of 'Druid'.

You can make a 'quick' fix for that behavior by reverting the order of the arrays:

$classes = array_reverse($classes);
$replacements = array_reverse($replacements);

But if you want one-to-one replacement, there is not really a need for str_replace. You can do something like this instead:

$class_index = array_search($class, $classes);
$resulting_class = $replacements[$class_index];

Collectives™ on Stack Overflow

PHP: Array translation problems

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related