Trying to iterate array of objects PHP

Question

I have a method in which I want to parse input from an SQL-Row into an object:

function buildPictureArray($sqlRow) {
   $pics = [];
   foreach($sqlRow as $value) {
      extract($value); // How to do this more elegant?
      $newObj = new PICObject($id, $filename, $thumb . $filename, $full . $filename, $title, $subtitle); // These are column names I got from extract
      $pics[] = $newObj;
   }
   return $pics;
}

My PICObject looks like this:

  Class PICObject {
    public $id;
    public $fileName;
    public $thumbLink;
    public $fullLink;
    public $title;
    public $subTitle;

    function __construct($id, $fileName, $thumbLink, $fullLink, $title, $subTitle) {
      $this->$id = $id;
      $this->$fileName = $fileName;
      $this->$thumbLink = $thumbLink;
      $this->$fullLink = $fullLink;
      $this->$title = $title;
      $this->$subTitle = $subTitle;
    }
  }

Now ideally I want to iterate this $pics array which should now contain several PICObjects and be able to access its fields:

foreach($pics as $picObj) {
   echo $picObj->$fileName;
}

However, this doesn't work. So how to do this? (I've tried it several ways but nothing really did what I was looking for)

check your syntax. $this->id not $this->$id, echo $picObj->fileName; not echo $picObj->$fileName; — check
– check, Commented Nov 4, 2015 at 7:47

Erik Theoboldt · Accepted Answer · 2015-11-04 13:39:08Z

2

You have to access the object attributes without the dollar sign, example:

foreach($pics as $picObj) {
   echo $picObj->fileName;
}

edited Nov 4, 2015 at 13:39

Erik Theoboldt

2,6982 gold badges18 silver badges21 bronze badges

answered Nov 4, 2015 at 7:47

S.Wall

365 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

octavio Over a year ago

It's working now. Also I had to remove the dollar signs in my class e.g. $this->id not $this->$id as mentioned by the user Phpstall.

John Pangilinan · Accepted Answer · 2015-11-04 07:41:49Z

0

try array_push($pics, $newObj); instead of $pics[] = $newObj;

edit:

can you post your extract(value) method?

answered Nov 4, 2015 at 7:41

John Pangilinan

1,0511 gold badge11 silver badges29 bronze badges

Comments

Phpstall · Accepted Answer · 2015-11-04 07:51:41Z

0

In the constructor class, you made a mistake

$this->$id = $id is wrong

$this->id = $id is correct

same for all other variables

answered Nov 4, 2015 at 7:51

Phpstall

661 silver badge6 bronze badges

1 Comment

octavio Over a year ago

This fixed it in combination with also accessing the object attributes without $.

Collectives™ on Stack Overflow

Trying to iterate array of objects PHP

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related