Angular Factory injection error

Question

I'm new to AngularJS and I'm learning Factory/Services. I coded this simple application to pass Fire Factory in Controller, but when I inject the Factory/Service in a controller it throws an error

home.html

<div class="home" ng-controller="HomeCtrl">
    Home <button ng-class="logut()">LogOut</button>
 {{test}}
</div>

app.js

cheers.factory('Fire',function($scope,$location,$firebaseObject){
  return  {name : 'Pawan Choudhary'};

});

cheers.controller('HomeCtrl', ['$scope','$location','Fire',function ($scope, $location,Fire) {    
    $scope.test = "working!";
}]);

It throws the following error:

you should define var factory = {} then creating functions and variables in factory , then return factory — MohammadJavad Seyyedi
– MohammadJavad Seyyedi, Commented Nov 5, 2015 at 7:35
@OP: I don't see how the code you have in your question could cause that issue. — Cerbrus
– Cerbrus, Commented Nov 5, 2015 at 7:41
Use the un-minified version of Angular for better error messages — Phil
– Phil, Commented Nov 5, 2015 at 7:42

Raman Choudhary · Accepted Answer · 2015-11-05 07:57:10Z

1

Ok! Thanks everyone I fixed the bug by removing $scope from the factory.

answered Nov 5, 2015 at 7:57

Raman Choudhary

4,4132 gold badges17 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Manouk · Accepted Answer · 2015-11-05 08:19:52Z

0

The header of your factory is not correct, if you wanted to add $scope, it must look like your controller header. try this :

cheers.factory('Fire',['$scope', '$location', '$firebaseObject', function($scope,$location,$firebaseObject){

         //your code

}]);

answered Nov 5, 2015 at 8:19

Manouk

136 bronze badges

Collectives™ on Stack Overflow

Angular Factory injection error

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related