Refactoring the "view" code

Question

My "view" code has an obvious repetition in its code. Is there any way of refactoring the "return" code?

def form_contractor_view(request):
    if request.method == 'POST':
        form = ContractorForm(request.POST)
        if form.is_valid():
            form.save()
            return redirect('index_view')
        else:
            return render_to_response(
                'form_contractor.html',
                {'form': form},
                context_instance=RequestContext(request),
            )
    else:
        form = ContractorForm()
        return render_to_response(
           'form_contractor.html',
           {'form': form},
           context_instance=RequestContext(request),
        )

I would very much recommend you to consider class-based views. — Wtower
– Wtower, Commented Nov 8, 2015 at 9:43

knbk · Accepted Answer · 2015-11-08 11:23:32Z

2

There is no need for the first else at all. Move the final render back an indent, and that will catch the else case. Note that this is the pattern explicitly described in the documentation.

Also, use render instead of render_to_response.

def form_contractor_view(request):
    if request.method == 'POST':
        form = ContractorForm(request.POST)
        if form.is_valid():
            form.save()
            return redirect('index_view')
    else:
        form = ContractorForm()
    return render(
       request,
       'form_contractor.html',
       {'form': form},
    )

edited Nov 8, 2015 at 11:23

knbk

53.9k9 gold badges130 silver badges128 bronze badges

answered Nov 8, 2015 at 9:55

Daniel Roseman

602k68 gold badges910 silver badges923 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Cloud Over a year ago

When the form is not valid, Django keeps producing the error saying that HttpResponse object is none. Therefore, to circumvent that error, I included the first "else". With your suggestion, invalid forms will not be redirected. Is there any way around that?

Daniel Roseman Over a year ago

No, that won't happen as long as you follow this pattern precisely: as I mentioned, the final return line must not be indented.

doniyor · Accepted Answer · 2015-11-08 10:18:26Z

0

I will give my try:

def form_contractor_view(request):
    form = ContractorForm(request.POST or None)
    if form.is_valid():
        form.save()
        return redirect(reverse('index_view')) # <-- you forgot reverse() here
    return render(
        request,
        'form_contractor.html',
        {'form': form}
    )

I replaced render_to_response with render which does the same thing - you just type less... try to be lazy ;)

I think, this works. not tested though. If request is not done in POST, then is_valid() returns False returning the form as None back again which makes sense. and for the case where the request is done in POST and invalid values in it, then else kicks in and returns the form with error messages... I think, this works.. please test

edited Nov 8, 2015 at 10:18

answered Nov 8, 2015 at 9:38

doniyor

38k62 gold badges183 silver badges272 bronze badges

3 Comments

Alasdair Over a year ago

Re: 'you forgot reverse()' - you don't need to call reverse first when using the redirect shortcut, it will reverse the URL for you!

doniyor Over a year ago

@Alasdair you mean redirect('index_view') will do the same thing?

doniyor Over a year ago

@Alasdair you are right: github.com/django/django/blob/master/django/… thanks for the trick

Collectives™ on Stack Overflow

Refactoring the "view" code

2 Answers 2

2 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related