While loop doesn't change the value of variable

Question

int time=0;
int x=1;
int w=2;
int y=1;
int h=1;
int t=6;
while (x != w && y != h) {
    boolean s = Abc (a,b,c,time);
    if (s == true) {
        time = time+t;
        x++;
    }
    else if (s = false) {
        time = time++;
    }
}

System.out.println(time);

This is a part of program I'm writing for school and my problem is that when the program enters the while loop no matter what I do inside the loop when it exits and prints the variable "time" the value is the same as the value set at the beginning. Am I missing something? (BTW Abc is just a method that should return the value true when I first enter the loop, therefore the value of time should be changed to time+t)

Try with else if (s == false) (even if it is a little too overkill) — dotvav
– dotvav, Commented Nov 9, 2015 at 13:19
s = false -> s == false else it will set s to false instead of comparing it, also time = time++ does nothing. Use time++ instead — dly
– dly, Commented Nov 9, 2015 at 13:20
The code you've posted will never enter the while loop, since y and h are equal. — Anthony Grist
– Anthony Grist, Commented Nov 9, 2015 at 13:22
You never need to compare a boolean; if (s) { ... } else { ... }; — molbdnilo
– molbdnilo, Commented Nov 9, 2015 at 13:22

Eran · Accepted Answer · 2015-11-09 13:30:25Z

7

s = false is an assignment, not a comparison. Anyway, you don't need to test if s == false, you just need an else clause (since the original condition checks for s == true).
There's no reason to assign the result of time++ to time, since it will undo the increment (the post increment operator returns the previous value of the variable, so when you assign that value back to the variable, you cancel the increment).

Change

else if (s = false) {
    time = time++;
}

to

else {
    time++;
}

Edit :

As Anthony Grist commented, even after these fixes, the entire while loop won't be executed at all, since y==h in the beginning.

edited Nov 9, 2015 at 13:30

answered Nov 9, 2015 at 13:19

Eran

395k57 gold badges726 silver badges793 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Andy Turner Over a year ago

Might be worth tipping a nod to @AnthonyGrist's comment, since these fixes don't make time change in and of themselves (UV anyway).

Eran Over a year ago

@AndyTurner I missed that. Thanks

Collectives™ on Stack Overflow

While loop doesn't change the value of variable

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related