Upload a file using HTTP put in Java

Question

I am writing a desktop app in Java to upload a file to a folder on IIS server using HTTP PUT.

URLConnection urlconnection=null;
  try{
   File file = new File("C:/test.txt");
   URL url = new URL("http://192.168.5.27/Test/test.txt");
   urlconnection = url.openConnection();
   urlconnection.setDoOutput(true);
   urlconnection.setDoInput(true);

   if (urlconnection instanceof HttpURLConnection) {
    try {
     ((HttpURLConnection)urlconnection).setRequestMethod("PUT");
     ((HttpURLConnection)urlconnection).setRequestProperty("Content-type", "text/html");
     ((HttpURLConnection)urlconnection).connect();


    } catch (ProtocolException e) {
     // TODO Auto-generated catch block
     e.printStackTrace();
    }
   }


   BufferedOutputStream bos = new BufferedOutputStream(urlconnection
     .getOutputStream());
   BufferedInputStream bis = new BufferedInputStream(new FileInputStream(
     file));
    int i;
    // read byte by byte until end of stream
    while ((i = bis.read()) >0) {
     bos.write(i);
    }
   System.out.println(((HttpURLConnection)urlconnection).getResponseMessage());
  }
  catch(Exception e)
  {
   e.printStackTrace();
  }
  try {

   InputStream inputStream;
   int responseCode=((HttpURLConnection)urlconnection).getResponseCode();
   if ((responseCode>= 200) &&(responseCode<=202) ) {
    inputStream = ((HttpURLConnection)urlconnection).getInputStream();
    int j;
    while ((j = inputStream.read()) >0) {
     System.out.println(j);
    }

   } else {
    inputStream = ((HttpURLConnection)urlconnection).getErrorStream();
   }
   ((HttpURLConnection)urlconnection).disconnect();

  } catch (IOException e) {
   // TODO Auto-generated catch block
   e.printStackTrace();
  }

This program creates an empty file on the destination folder (Test). The contents are not written to the file.

What is wrong with this program?

I'd start by debugging the server-side - are the bytes actually received? — Bozho
– Bozho, Commented Aug 2, 2010 at 10:24
My first approach on write operations that don't produce any content is flushing every stream I have :D Try bos.flush() after writing. — f1sh
– f1sh, Commented Aug 2, 2010 at 10:31

Devon_C_Miller · Accepted Answer · 2010-08-02 14:21:42Z

5

After you complete the loop where you are writing the BufferedOutputStream, call bos.close(). That flushes the buffered data before closing the stream.

answered Aug 2, 2010 at 14:21

Devon_C_Miller

16.5k3 gold badges48 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chen Harel · Accepted Answer · 2012-02-02 09:18:34Z

1

Possible bug: bis.read() can return a valid 0. You'll need to change the while condition to >= 0.

answered Feb 2, 2012 at 9:18

Chen Harel

10.1k5 gold badges48 silver badges60 bronze badges

Collectives™ on Stack Overflow

Upload a file using HTTP put in Java

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related