Counting Sort Implementation in C#

Question

I am implementing counting sort But some thing is wrong with my code I am new in Programming Please help me to find an error. I am implenting it step by step .

    namespace ConsoleApplication1
    {
        class Program
        {
            public static int[] a = { 0,0,0,5,4,8,9,9,7,3, 3, 2, 1 };
            public static void Sorting()
            {
                int j = 0, i = 0, smallestvalue = 0, largestvalue = 0, n = a.Length, lengthof_B = 0, temp = 0, anothersmallestvalue;
                smallestvalue = largestvalue = a[0];
                for (i = 0; i < n; i++)
                {
                    if (smallestvalue > a[i])
                    {
                        smallestvalue = a[i];
                    }
                    else if (largestvalue < a[i])
                    {
                        largestvalue = a[i];
                    }
                }
                int x = anothersmallestvalue = smallestvalue;

                lengthof_B = largestvalue - smallestvalue + 1;
                int[] b = new int[lengthof_B];
                for (i = 0; i < lengthof_B && smallestvalue <= largestvalue; i++)
                {
                    for (j = 0; j < n; j++)
                    {
                        if (smallestvalue == a[j])
                        {
                            b[i] = b[i] + 1;
                        }
                    }
                    b[i] = temp + b[i];
                    temp = b[i];
                    smallestvalue++;
                }
                int[] c = new int[a.Length];
                                                // I think error here 
                for (i = n - 1; i >= 0; i--)
                {
                    anothersmallestvalue = x;
                    for (j = 0; j <= lengthof_B ; j++)        
                    {

                        if (a[i] == anothersmallestvalue)
                        {
                            temp = b[j];
                            c[temp - 1] = anothersmallestvalue;
                            b[j] = b[j];
                        }
                        anothersmallestvalue++;
                    }
                }            
                for (i = 0; i < c.Length; i++)
                {
                    Console.WriteLine("c[i] : " + c[i]);
                }
            }
        }
        class Demo
        {
            static void Main(string[] args)
            {
                Program.Sorting();
                Console.ReadLine();
            }
        }
    }

Desired Output is

000123457899

But output of my program is

000120457809

why so many variables? that just makes things confusing and harder to debug. also counting sort does not have nested loop anyway. — M.kazem Akhgary
– M.kazem Akhgary, Commented Nov 28, 2015 at 17:16
Sorry for too many variables But I am stuck on this from 1 day — Nafees
– Nafees, Commented Nov 28, 2015 at 17:17
the very simple and stylish way is described and shown here. en.wikipedia.org/wiki/Counting_sort#The_algorithm — M.kazem Akhgary
– M.kazem Akhgary, Commented Nov 28, 2015 at 17:19
I saw this but i want to implement it with my own thinking,, — Nafees
– Nafees, Commented Nov 28, 2015 at 17:25

Syed Qasim Ahmed · Accepted Answer · 2015-11-28 17:18:44Z

4

This Is Your Code Here I found a mistake.

And your Code is too complex Please Go through your code Once more.

for (i = n - 1; i >= 0; i--)
                {
                    anothersmallestvalue = x;
                    for (j = 0; j <= lengthof_B ; j++)        
                    {

                        if (a[i] == anothersmallestvalue)
                        {
                            temp = b[j];
                            c[temp - 1] = anothersmallestvalue;
                            b[j] = b[j] -1 ;// Possible Mistake I think here
                        }
                        anothersmallestvalue++;
                    }
                }

the very simple and stylish way is described and shown here.

en.wikipedia.org/wiki/Counting_sort#The_algorithm

answered Nov 28, 2015 at 17:18

Syed Qasim Ahmed

1,36213 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

chue x Over a year ago

Nice find but I think OP's code is b[j] = b[j] (without the -1)

Syed Qasim Ahmed Over a year ago

Yes I add '-1` at my own

jdweng · Accepted Answer · 2015-11-28 17:33:35Z

1

Normal sorting your two loops should look like this

for (i = 0; i < lengthof_B - 1; i++)
{
    for (j = i + 1; j < lengthof_B; j++)
    {
    }
}

answered Nov 28, 2015 at 17:33

jdweng

34.5k3 gold badges17 silver badges19 bronze badges

1 Comment

M.kazem Akhgary Over a year ago

op didnt ask for bubble sort way.

Collectives™ on Stack Overflow

Counting Sort Implementation in C#

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related