Javascript function scope / order of execution issue

Question

I'm having an issue with the javascript scope / order of execution. I create an empty object inside a function. Then I add some properties in a child function. The properties haven't changed in the parent function, though.

$scope.finder = function (obj) {

    var id = obj.oid;

    var crit = MC.Criteria('_ownerUserOid == ?', [id]);

    theResult = {}; // Scope should be finder function.

    database.findOne(crit) // This is a Monaca method for finding from database

    .done(function(result) {
        // Returns and empty object as expected.
        console.log(JSON.stringify(theResult));

        theResult = result;

        // Returns the search result object as again expected.
        console.log(JSON.stringify(theResult));
    });



// Here's the issue - when I log and return theResult, I get an empty object again.
// I think it has to do something with the scope.
// Also, this logs to console before either of the console.logs in the done function.

    console.log(JSON.stringify(theResult));
    return theResult;


};

By the time the child function finishes, the console log has already executed, which is why "theResult" prints empty in that line. — Bhargav Ponnapalli
– Bhargav Ponnapalli, Commented Nov 30, 2015 at 17:21
You forgot var. The variable theResult is therefore global. — Pointy
– Pointy, Commented Nov 30, 2015 at 17:22

Albondi · Accepted Answer · 2015-11-30 17:25:59Z

1

I think you forgot the "var" before declaring the variable

var theResult = {}

answered Nov 30, 2015 at 17:25

Albondi

1,1511 gold badge8 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

James Craig · Accepted Answer · 2015-11-30 17:36:28Z

It looks like you are performing an asynchronous request for some data. Any time you are performing asynchronous JavaScript, you will need to keep in mind that things aren't called sequentially. When an asynchronous call is made, JavaScript will carry on executing code down the stack.

In your case, theResult will be an empty object because database.findOne(crit) has not finished executing by the time you call console.log(JSON.stringify(theResult));

Because of this, you cannot return from $scope.finder, instead you could pass a callback into $scope.finder and execute that once database.findOne(crit) has finished executing.

$scope.finder = function (obj, callback) {

    var id = obj.oid;

    var crit = MC.Criteria('_ownerUserOid == ?', [id]);

    theResult = {}; // Scope should be finder function.

    database.findOne(crit) // This is a Monaca method for finding from database

        .done(function(result) {
            // Returns and empty object as expected.
            console.log(JSON.stringify(theResult));

            theResult = result;

            callback(theResult);

            // Returns the search result object as again expected.
            console.log(JSON.stringify(theResult));
        });
};

Then call it like this.

$scope.finder({some: 'data'}, function(response) {
    // response now has the values of theResult
    console.log(response)
});

Ben Aston · Accepted Answer · 2015-11-30 17:31:27Z

0

Change it to this:

$scope.finder = function (obj) {   
    return database.findOne(MC.Criteria('_ownerUserOid == ?', [obj.oid]));        
};

// Client code:
finder({ oid: 'foo' })
  .then(function(result) { console.log(JSON.stringify(result)); });

answered Nov 30, 2015 at 17:31

Ben Aston

56k69 gold badges221 silver badges351 bronze badges

Collectives™ on Stack Overflow

Javascript function scope / order of execution issue

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related