changing buttons within tkinter

Question

win=Tk()
level1=matrixmaker(4)

def display(x,y): 
if z["text"] == " ":
    # switch to Goodbye
    z["text"] = level1[x][y]
else:
    # reset to Hi
    z["text"] = " "


for x in range(0,4):
    for y in range(0,4):
        z=Button(win,text=" ", command=display(x,y))
        z.grid(row=x,column=y)

I have this code but I don't know how to get the display function to work. How can I call the button and change the text without it having a hardcoded variable name?

In Tkinter, the command argument is a reference to a function, not the function itself. You have to make the argument into command=display with no arguments. See here: stackoverflow.com/questions/6920302/… — Colby Gallup
– Colby Gallup, Commented Dec 1, 2015 at 23:30
Also, you're calling a three argument function with only two arguments (that can't be added anyway). — Colby Gallup
– Colby Gallup, Commented Dec 1, 2015 at 23:32
i added the lambda but now whenever i click anything on the grid it only changes the bottom right button — Laura
– Laura, Commented Dec 1, 2015 at 23:38
because you change z - but z is the last button created in for loop. — furas
– furas, Commented Dec 1, 2015 at 23:39

MrAlexBailey · Accepted Answer · 2015-12-01 23:45:35Z

4

You can't assign the command to the button with the called function (display(x, y)) because this assigned what this function returns (None) to the button's command. You need to assign the callable (display) instead.

To do this and pass arguments you'll need to use a lambda:

z = Button(win, text='')
z['command'] = lambda x=x, y=y, z=z: display(x, y, z)
z.grid(row=x, column=y)

Also, you'll want to change your display() function to accept another argument z so that the correct button gets changed (and correct the indentation):

def display(x,y,z): 
    if z["text"] == " ":
        # switch to Goodbye
        z["text"] = level1[x][y]
    else:
        # reset to Hi
        z["text"] = " "

edited Dec 1, 2015 at 23:45

answered Dec 1, 2015 at 23:40

MrAlexBailey

5,2791 gold badge21 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

furas Over a year ago

you should add - OP needs to use def display(x,y,z) in place of def display(x,y)

MrAlexBailey Over a year ago

@furas Thanks for pointing this out (before the OP edited the question it was defined as def display(x,y,z))

Collectives™ on Stack Overflow

changing buttons within tkinter

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related