Java use boolean for if statement and change if needed

Question

I'm new to java and unfortunately my brain is fixed in javascript land... This isn't good.

Anyways, I'm trying to just make a simple menu open and close using java. I have this script:

public class StartPage extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_start_page);

        //Handlers
        RelativeLayout menuContainer = (RelativeLayout) findViewById(R.id.MenuContainer);
        ImageView menuButton = (ImageView) findViewById(R.id.temp_menu);
        Boolean menuOpen = false;
        //Make sure the menu is not displaying
        menuContainer.setVisibility(View.GONE);

        menuButton.setOnClickListener(new View.OnClickListener() {
            public void onClick(View v) {
                if (!menuOpen) {
                    boolean menuOpen = true;
                    RelativeLayout menuContainer = (RelativeLayout) findViewById(R.id.MenuContainer);
                    menuContainer.setVisibility(View.VISIBLE);
                } else {
                    boolean menuOpen = false;
                    RelativeLayout menuContainer = (RelativeLayout) findViewById(R.id.MenuContainer);
                    menuContainer.setVisibility(View.GONE);
                }
            }
        });
    }
}

So, I make the variable menuOpen false right off the bat, but I want to use and manipulate that variable in an if statement.

I get an error in the if statement that says I need to make the variable final, so I make it final, but then I'm not able to change that variable later on.

This is my javascript brain thinking, so I'm not sure if there's a better way to do this in Java. Any help?

I'm 99% sure that you don't need if (menuOpen == false), you can just use if (!menuOpen) — Blue Eyed Behemoth
– Blue Eyed Behemoth, Commented Dec 2, 2015 at 21:58
Oh yeah, sorry - that's what I had before just if(!menuOpen), I was playing around a lot with it just as trial and error — ntgCleaner
– ntgCleaner, Commented Dec 2, 2015 at 21:58
Don't declare menuOpen inside a method, as it will go out of scope as soon as the method finishes. Try declaring it inside the class. — Luke Joshua Park
– Luke Joshua Park, Commented Dec 2, 2015 at 21:59
Make menuOpen as member variable of the class StartPage. Then access it using StartPage .this.menuOpen inside anonymous class. — ashiquzzaman33
– ashiquzzaman33, Commented Dec 2, 2015 at 22:00

ntgCleaner · Accepted Answer · 2015-12-02 22:03:31Z

2

Make menuOpen as member variable of the class StartPage. Then access it using StartPage .this.menuOpen inside anonymous class.

public class StartPage extends Activity {
    boolean menuOpen = false;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_start_page);

        //Handlers
        RelativeLayout menuContainer = (RelativeLayout) findViewById(R.id.MenuContainer);
        ImageView menuButton = (ImageView) findViewById(R.id.temp_menu);
        //Make sure the menu is not displaying
        menuContainer.setVisibility(View.GONE);

        menuButton.setOnClickListener(new View.OnClickListener() {
            public void onClick(View v) {
                if (!StartPage.this.menuOpen) {
                    StartPage.this.menuOpen = true;
                    RelativeLayout menuContainer = (RelativeLayout) findViewById(R.id.MenuContainer);
                    menuContainer.setVisibility(View.VISIBLE);
                } else {
                    StartPage.this.menuOpen = false;
                    RelativeLayout menuContainer = (RelativeLayout) findViewById(R.id.MenuContainer);
                    menuContainer.setVisibility(View.GONE);
                }
            }
        });

    }
}

edited Dec 2, 2015 at 22:03

ntgCleaner

6,00510 gold badges54 silver badges87 bronze badges

answered Dec 2, 2015 at 22:02

ashiquzzaman33

5,7375 gold badges34 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ntgCleaner Over a year ago

Added my working script to your answer, will accept in 7 minutes

csenga · Accepted Answer · 2016-01-13 14:09:15Z

0

Just put the menuOpen varible outside of the method.

public class StartPage extends Activity {

 Boolean menuOpen = false;
    @Override
    protected void onCreate(Bundle savedInstanceState) {

This way the listener's class has access to it.

edited Jan 13, 2016 at 14:09

answered Dec 2, 2015 at 22:03

csenga

4,1142 gold badges24 silver badges33 bronze badges

Collectives™ on Stack Overflow

Java use boolean for if statement and change if needed

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related