ERB Javascript conditional error

Question

I am trying to run the following lines in my Rails app in an erb file:

<script>
  if("<%=current_user%>".length>0){
    console.log('set mixpanel current user');
    mixpanel.identity("<%=current_user.id%>");
  }else{
    console.log('set mixpanel identity to 0');
    mixpanel.identify('0');
  }
</script>

I am getting errors with the line containing <%=current_user.id%>, which seems to be analyzed even if the conditional is not satisfied:

Called id for nil, which would mistakenly be 8 -- if you really wanted the id of nil, use object_id

How do I handle a javascript conditional with a ruby variable?

K M Rakibul Islam · Accepted Answer · 2015-12-04 21:15:13Z

4

In erb file, we can embed ruby code using scriptlets: <% %>.

This should work:

<script>
  <% if current_user %>
    console.log('set mixpanel current user');
    mixpanel.identity("<%=current_user.id%>");
  <% else %>
    console.log('set mixpanel identity to 0');
    mixpanel.identify('0');
  <% end %>
</script>

edited Dec 4, 2015 at 21:15

K M Rakibul Islam

34.4k13 gold badges95 silver badges113 bronze badges

answered Dec 4, 2015 at 18:58

Pardeep Dhingra

3,9467 gold badges35 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dushyant · Accepted Answer · 2015-12-04 19:00:01Z

0

current_user instead of "<%=current_user%>".length>0 would work I guess.

answered Dec 4, 2015 at 19:00

Dushyant

4,9903 gold badges20 silver badges24 bronze badges

Collectives™ on Stack Overflow

ERB Javascript conditional error

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related