Array on python function

Question

Please help. It's really children's question but I'm at a loss. Why I can't to return array?

There is my script :

groups=[]

host_groups_list = '/usr/local/host_groups.list'

def read_file(file_path):
        open_file = open(host_groups_list, "r+")
        list=[]
        for i in open_file:
                list.append(str(i.replace("\n", "")))
        print list
        return list

goups = read_file(host_groups_list)
print groups

Output :

['hostgroup1', 'hostgroup2']
[]

1. You didn't close that file after you open it. 2. A typo and use list as variable name as Mike said. 3. list.append(str(i.replace("\n", ""))), str() is useless here. 4. I think you mean open_file = open(file_path, "r+") instead of open_file = open(host_groups_list, "r+"). 5. groups = with open(''/usr/local/host_groups.list'') as f: [i.strip() for i in f]. — Remi Guan
– Remi Guan, Commented Dec 6, 2015 at 3:53

Remi Guan · Accepted Answer · 2015-12-06 03:48:51Z

3

Spelling is important:

goups = read_file(host_groups_list)
print groups

Note the missing r in goups.

You don't need the groups=[] in the beginning. Delete it and Python will give a name error for your print statement.

Better don't use list as a name for your variables because it shadows a built-in.

edited Dec 6, 2015 at 3:48

Remi Guan

22.5k17 gold badges68 silver badges90 bronze badges

answered Dec 5, 2015 at 15:00

Mike Müller

86k21 gold badges174 silver badges165 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

GingerPlusPlus Over a year ago

@JustMe: use editor with auto-completion (I personally recommend Sublime Text 2) to avoid mistakes like this in future. And, don't create unneeded globals.

Collectives™ on Stack Overflow

Array on python function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related