C# error parsing to query

Question

System.Data.SqlServerCeException (0x80004005): There was an error parsing to the query. [Token line number = 1, Token line offset = 120, Token in error = @price ]

I keep getting this error when running my program and I can't figure out what I'm doing wrong. I've tried changing multiple things around and it keeps giving the same error, just the number after "Token line offset = " changes sometimes.

static public void Insert(string _id, string _city, string _state, string _country, int _beds, int _baths, int _price)
{
        try
        {
            connection.Open();
            SqlCeCommand commandInsert = new SqlCeCommand("INSERT INTO [House] (id, city, state, country, beds, baths, price) VALUES (@id, @city, @state, @country, @beds, @baths, @price", connection);
            commandInsert.Parameters.AddWithValue("@id", _id);
            commandInsert.Parameters.AddWithValue("@city", _city);
            commandInsert.Parameters.AddWithValue("@state", _state);
            commandInsert.Parameters.AddWithValue("@country", _country);
            commandInsert.Parameters.AddWithValue("@beds", _beds);
            commandInsert.Parameters.AddWithValue("@baths", _baths);
            commandInsert.Parameters.AddWithValue("@price", _price);
            commandInsert.ExecuteNonQuery();
        }
        catch (SqlCeException exception)
        {
            MessageBox.Show(exception.ToString());
        }
        finally
        {
            connection.Close();
        }
}

Code within buttonclick

private void btn_insert_Click(object sender, EventArgs e)
{
        if (txt_id.Text != "" && txt_city.Text != "" && txt_state.Text != "" && txt_country.Text != "")
        {
            SQLFunctions.Insert(txt_id.Text, txt_city.Text, txt_state.Text, txt_country.Text, int.Parse(txt_beds.Text), int.Parse(txt_baths.Text), int.Parse(txt_Price.Text));
            SQLFunctions.Refresh(this.dataGridView1);
        }
}

Soner Gönül · Accepted Answer · 2015-12-05 18:49:42Z

3

I think you forget to close your VALUES( part with ) after your @price parameter.

VALUES (@id, @city, @state, @country, @beds, @baths, @price)

A few things more;

Use using statement to dispose your connection and command automatically instead of calling close method manually.
Do not use AddWithValue method as much as possible. It may generate unexpected and surprising results sometimes. Use Add method overload to specif your parameter type and it's size.

answered Dec 5, 2015 at 18:49

Soner Gönül

99.1k103 gold badges224 silver badges375 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Alex Over a year ago

I was using Add initially but then it kept underlining my code in green and said it was obsolete or something and to use AddWithValue and it went away.

Soner Gönül Over a year ago

@Alex Only Add(String, Object) overload is obsolete. You can use Add(String, SqlDbType, Int32) overload instead.

shaikh · Accepted Answer · 2015-12-05 19:23:50Z

Try this

query="INSERT INTO [House] (id, city, state, country, beds, baths, price) VALUES ('@id', '@city', '@state', '@country', '@beds', '@baths', '@price')";

and replace your try with this

 connection.Open();
            SqlCeCommand commandInsert = new SqlCeCommand(query, connection);
            commandInsert.Parameters.AddWithValue("id", _id);
            commandInsert.Parameters.AddWithValue("city", _city);
            commandInsert.Parameters.AddWithValue("state", _state);
            commandInsert.Parameters.AddWithValue("country", _country);
            commandInsert.Parameters.AddWithValue("beds", _beds);
            commandInsert.Parameters.AddWithValue("baths", _baths);
            commandInsert.Parameters.AddWithValue("price", _price);
            commandInsert.ExecuteNonQuery();

Collectives™ on Stack Overflow

C# error parsing to query

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related