Fill ListBox with db query results

Question

As the title suggests, I'm trying to fill a ListBox with the results of a db query, though I'm not sure how to manage this. I've managed to populate a DataGrid from another query, but I'm not sure how to do the same with a ListBox. I'm sure it's simple, but I'm missing something! Similar overflow pages/google searches haven't yet yielded a clear answer. I'm using c# in a WPF app in visual studio.

In a separate class I have this:

public DataTable FillAllMenuItems()
{
     SqlConnection con = new SqlConnection(@"Data Source=(LocalDB)\MSSQLLocalDB;AttachDbFilename=C:\Users\DustCatcher\Documents\pizzeria.mdf;Integrated Security=True;Connect Timeout=30");
     SqlCommand cmd = new SqlCommand("SELECT name FROM MenuItems", con);
     SqlDataAdapter sda = new SqlDataAdapter(cmd);
     DataTable dt = new DataTable("Menu Items");
     sda.Fill(dt);
     return dt;
}

As an aside, I'm sure the above is messy so any pointers there would be great (do I need a using anywhere there?). On the relevant window cs file I have:

User user = User.GetInstance();
lstbxAllItems.ItemsSource = user.FillAllMenuItems().DefaultView;

Running the app, the ListBox has System.Data.DataRowView as many times as there are items in the database. Where am I going wrong?

Set the ValueMemberPath and DisplayMemberPath of your ListBox also I would recommend to use using statements for your SqlConnection, SqlCommand etc. Link for the ItemSource stackoverflow.com/questions/1790878/… — Sybren
– Sybren, Commented Dec 7, 2015 at 15:40

Salah Akbari · Accepted Answer · 2015-12-07 16:01:52Z

2

You need to set lstbxAllItems.DisplayMemberPath after lstbxAllItems.ItemsSource:

lstbxAllItems.DisplayMemberPath = "Name"; // Or any column you want to show in your ListBox

But as a better approach you can use ListView.ItemTemplate and Binding for this purpose. Something like this:

<ListBox Name="lstbxAllItems">
    <ListBox.ItemTemplate>
        <DataTemplate>
            <TextBlock Text="{Binding Name}"></TextBlock>
        </DataTemplate>
    </ListBox.ItemTemplate>
</ListBox>

edited Dec 7, 2015 at 16:01

answered Dec 7, 2015 at 15:42

Salah Akbari

40k10 gold badges85 silver badges115 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Penta Over a year ago

Thanks very much for this, adding displaymemberpath did the trick! I'll read up a bit more about your suggested alternate method, as I'm not too sure how to implement it correctly!

Charitini · Accepted Answer · 2015-12-09 08:13:48Z

1

private void BindListbox() 
{
    myListBox.DataSource = dt;
    myListBox.DisplayMemberPath = "Name";
}

edited Dec 9, 2015 at 8:13

answered Dec 7, 2015 at 15:48

Charitini

338 bronze badges

2 Comments

Penta Over a year ago

Thanks for the answer, though I wanted to avoid further methods before I get bogged down in them all!

Salah Akbari Over a year ago

In WPF DisplayMember should be DisplayMemberPath. Please edit your answer and change it to DisplayMemberPath.

Collectives™ on Stack Overflow

Fill ListBox with db query results

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related