javascript if statement optimization on array-length flag

Question

How should I write following javascript function in a better way?

  function showIssueCount(issueSummary){
    if(issueSummary["CRITICAL"] >= 1){
      return {value:issueSummary["CRITICAL"], class:"CRITICAL" };
    }else if(issueSummary["MAJOR"] >= 1 ){
      return {value:issueSummary["MAJOR"], class:"MAJOR" };
    }else if (issueSummary["MINOR"] >= 1){
      return {value:issueSummary["MINOR"], class:"MINOR" };
    }else{
      return {vaue:0, class:""}
    }
  }

the issueSummary object will be of following type. {"CRITICAL": 1, "MAJOR": 1, "MINOR":1} — user3721335
– user3721335, Commented Dec 10, 2015 at 8:42

gurvinder372 · Accepted Answer · 2015-12-10 08:51:06Z

2

something like this

function showIssueCount( obj )
{
    var priority = [ 'CRITICAL', 'MAJOR', 'MINOR' ];
    for( var counter = 0; counter < priority.length; counter++ )
    {
        if ( obj[ priority[ counter ] ] >= 1 )
        {
            return { value : obj[ priority[ counter ] ], class: priority[ counter ] };
        }       
    }
    return {value:0, class:""}
}

edited Dec 10, 2015 at 8:51

answered Dec 10, 2015 at 8:47

gurvinder372

68.6k11 gold badges78 silver badges98 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Shanoor Over a year ago

You made a little mistake, the return is an object, you used [ ].

gurvinder372 Over a year ago

@ShanShan thanks for pointing it without downvoting :) . made the changes

Shanoor Over a year ago

No problem, I was about to post the same code but you were faster so upvote it was :)

Collectives™ on Stack Overflow

javascript if statement optimization on array-length flag

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related