Troubles passing string to ajax via javascript function

Question

I'm getting some issues with a function, where i'm passing 2 arguments, one of them contains a string "12345.00" the main problem is that on console.log(string) this return only "12345".

Is there a way to get the entire string?

$data = array(
  array(
    'arg1' => '1', 
    'arg2' => '123'
  ),
  array(
    'arg1' => '2', 
    'arg2' => '12345.00'
  )
);

<button id="openTab">Test</button>

foreach($data as $item){
  <script>                          
    $('#openTab').click(function(e){
      e.preventDefault();
      getValues(<?php echo $item['arg1'](); ?>, <?php echo $item['arg2']; ?>);
    });                         
  </script>
}

function getValues(arg1, arg2){
  console.log(arg2);
  new Ajax.Request("<?php echo $this->getUrl('getValues') ?>", {
    method: 'POST',
    type: 'json',
    parameters: { arg1: arg1, arg2: arg2},
    onComplete: function(transport) {
      var result = JSON.parse(transport.responseText);         
      console.log(result);     
    }
  });
}

What browser are you using? The code you've provided returns the string "12345.00" in Chrome. — James Donnelly
– James Donnelly, Commented Dec 17, 2015 at 15:29
Welcome to JS type coercion. But are you sure? I can't reproduce this: getValues('1', '12345.00'); > 12345.00 Are you manipulating the value in any other way? — Dave Newton
– Dave Newton, Commented Dec 17, 2015 at 15:29
That's what happens when you convert the string 12345.00 to a number, so there's code missing from the example. — adeneo
– adeneo, Commented Dec 17, 2015 at 15:32
I have added my entire script, and on console.log this pass only the string without .00 — ndAR
– ndAR, Commented Dec 17, 2015 at 15:37

Dave Newton · Accepted Answer · 2015-12-17 15:42:00Z

1

getValues(<?php echo $item['arg1'](); ?>, <?php echo $item['arg2']; ?>);

This renders:

getValues(2, 12345.00);

You need to quote them if you want JS strings:

getValues("<?php echo $item['arg1'](); ?>", "<?php echo $item['arg2']; ?>");

Which renders:

getValues("2", "12345.00");

This can be verified by looking at the rendered JS.

You should also code defensively and assume the data that comes back might have quotes in it, e.g., it should be JavaScript-escaped before rendering it into JS.

It's important to understand that your file is basically a template. What happens on the client side is entirely dependent on how it's rendering. You can inspect the rendering by viewing source or inspecting elements to validate what's actually coming across to the browser.

answered Dec 17, 2015 at 15:42

Dave Newton

161k27 gold badges263 silver badges310 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ndAR Over a year ago

You're right, quoting the values I've resolved the issue !. Thx a lot

Collectives™ on Stack Overflow

Troubles passing string to ajax via javascript function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related