Simple TypeScript constructor variables interpreted as services (AngularJS with TypeScript)

Question

I have a simple controller and interface set up with TypeScript.

module signup { 

    // define signup interface for signup home controller
    interface ISignupCredentials {
        firstName: string;
        companyEmail: string;
        password: string;
    }

    export class SignupCtrl implements ISignupCredentials {

        static IID = "SignupCtrl";          
        constructor(public firstName: string,
                    public companyEmail: string,
                    public password: string) {                      

                    }                   
    }

    angular
        .module("signup", [])
        .controller(SignupCtrl.IID, SignupCtrl)     

}

I'm getting this error:

It looks like Angular thinks these are services, but I'm not sure why. I'm missing something completely here, but I can't see what it is. Any help would be appreciated! Thanks.

Could it be that you're not exporting that module? Try export module signup or even just remove that line. — Louay Alakkad
– Louay Alakkad, Commented Dec 20, 2015 at 22:02

dfsq · Accepted Answer · 2015-12-20 22:10:41Z

1

The problem is that controller construct method is indeed defines services, because it's called by Angular with necessary dependencies passed in. You don't construct controller instances manually.

Proper interface implementation would be:

// define signup interface for signup home controller
interface ISignupCredentials {
    firstName: string;
    companyEmail: string;
    password: string;
}

export class SignupCtrl implements ISignupCredentials {

    static IID = "SignupCtrl";

    firstName: string;
    companyEmail: string;
    password: string;

    constructor() {
        // ...
    }
}

angular
    .module("signup", [])
    .controller(SignupCtrl.IID, SignupCtrl)

answered Dec 20, 2015 at 22:10

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Thomas Over a year ago

Perfect, this worked! Thank you for the explanation :)

Collectives™ on Stack Overflow

Simple TypeScript constructor variables interpreted as services (AngularJS with TypeScript)

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related