Using Replace With for Returning Last Value of an Array

Question

I have a for loop in part with an array inside an object. It replaces, but it will only change the word(s) that are at the back of the array.

<textarea id='inp'></textarea>
<button onClick='rd()'>
k m8
</button>
<div id='res'>
</div>

<script>
var rd = function() {
var rep = "";
var inpt = document.getElementById('inp').value;
    for (i = 0; i < dict.before.length; i++) {
    var rep = inpt.replace(dict.before[i],dict.after[i]);
  }
  document.getElementById('res').innerHTML = rep;
}

var dict = {
    before : ["for","to","too"],
  after : ["4","2","2"]
}
</script>

If at the end of the before array, the value was "this" and after would be "that", all the other strings in each array would not work, they do not replace.

Terry · Accepted Answer · 2015-12-21 00:31:44Z

1

That is because you are overwriting the rep variable in each iteration of the for loop. You can simply perform replacement using the original init, i.e., change this line:

 var rep = inpt.replace(dict.before[i],dict.after[i]);

…to this line:

inpt = inpt.replace(dict.before[i],dict.after[i]);

And use the replaced inpt to set the innerHTML: document.getElementById('res').innerHTML = inpt;

See working example below:

var rd = function() {
  var rep = "";
  var inpt = document.getElementById('inp').value;
  for (i = 0; i < dict.before.length; i++) {
    inpt = inpt.replace(dict.before[i], dict.after[i]);
  }
  document.getElementById('res').innerHTML = inpt;
}

var dict = {
  before: ["for", "to", "too"],
  after: ["4", "2", "2"]
}

<textarea id='inp'></textarea>
<button onClick='rd()'>
  k m8
</button>
<div id='res'>
</div>

edited Dec 21, 2015 at 0:31

answered Dec 21, 2015 at 0:13

Terry

66.7k16 gold badges107 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

bubster20 Over a year ago

The problem is it only replaces once, and when it should replace after it, it doesn't.

Collectives™ on Stack Overflow

Using Replace With for Returning Last Value of an Array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related