Php - form validation, inconsistent results

Question

I recently created a PHP form (my first one) and I wanted to have a phone number validation feature. Now, I have written the code. But it works for two or three runs and then stops working all together. I don't get any errors. It simply accepts anything that I type in. The rest of the validations (name and radio button entries) work without a problem. I am checking for a 10-digit number (no special characters). The validation must check the length of the entry and should ensure only numbers are entered.

What am I doing wrong here?

if (empty($_POST["mobile"])) {
    $mobileerr = "Mobile number is required";
} else {
    $mobile = test_input($_POST["mobile"]);
    if (preg_match('/[^0-9]{10}/', $mobile)) {
        $mobileerr = "Please enter a valid 10-digit mobile number";
    } else {
        $postmobile = true;
    }
}

function test_input($data) {
    $data = trim($data);
    $data = stripslashes($data);
    $data = htmlspecialchars($data);
    return $data;
}

Please check any other javascript error using firebug. If you encounter any java script error while loading your page, it will not work as expected. — Elixir Techne
– Elixir Techne, Commented Dec 21, 2015 at 8:19
Thank you for replying. I have not included any javascript whatsoever. The page contains HTML, CSS and PHP. However, I have noticed that if I remove the code and type it in again, it starts working. This has happened twice until now. — Eightytwo
– Eightytwo, Commented Dec 21, 2015 at 9:02

LetsSeo · Accepted Answer · 2015-12-21 11:03:45Z

3

How about change this code:

if (preg_match('/[^0-9]{10}/', $mobile)) {
        $mobileerr = "Please enter a valid 10-digit mobile number";
    }

with this one;

if(strlen($mobile) != 10 || $mobile != ctype_digit($mobile)) {
$mobilerr = "Please..";
}

It will check if user input 10 character long and if it's contains only numbers.

edited Dec 21, 2015 at 11:03

answered Dec 21, 2015 at 10:34

LetsSeo

8757 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Eightytwo Over a year ago

Thanks for the tip, LetsSeao, this didn't work. I entered a full 10-digit number and it still gave an error asking for a valid entry to be made.

Eightytwo Over a year ago

UPDATE: This worked. I made a small mistake which caused it to fail. Now I have to check if it continues working without failing like earlier. Thank you, LetsSeo!

LetsSeo Over a year ago

I'm happy to be helpful. You can accept my answer if you like :)

Eightytwo Over a year ago

Accepted! I hope it works consistently. Thank you! :)

Elixir Techne · Accepted Answer · 2015-12-21 10:43:07Z

0

initilaize

$postmobile = false;

at beginning and then at end check if it is true of false.

Your modified version of code could be

function test_input($data) {
    $data = trim($data);
    $data = stripslashes($data);
    $data = htmlspecialchars($data);
    return $data;
}

$postmobile = false;
if (empty($_POST["mobile"])) {
    $mobileerr = "Mobile number is required";
} else {
    $mobile = test_input($_POST["mobile"]);
    if (preg_match('/[^0-9]{10}/', $mobile)) {
        $mobileerr = "Please enter a valid 10-digit mobile number";
    } else {
        $postmobile = true;
    }
}

if ($postmobile === false) {
    die("Invalid Mobile Number"); //Here you can postback error message and skip further execution.
}

answered Dec 21, 2015 at 10:43

Elixir Techne

1,85615 silver badges21 bronze badges

1 Comment

Eightytwo Over a year ago

I had already set $postmobile to false. I'm sorry I didn't mention it. But the problem is not with $postmobile. The validation itself is not returning the required result and I'm not able to figure out why.

Collectives™ on Stack Overflow

Php - form validation, inconsistent results

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related