Class Function does not return array properly

Question

I can't seem to get the array to return from the function correctly, every time I run the script it just echoes out 0, even though I have checked that the MySQL query returned at least 1 row. I've also tried using $_GLOBALS["FORUM_ANSWERS"][] = ..., however it still did not work.

public function getAnswers() {
    $dbh = $this->dbh;
    $id = $this->question_id;
    $q = $dbh->prepare("SELECT * FROM answers WHERE question_id = :id");
    $q->bindParam(":id", $id);
    $q->execute();
    $nr = $q->rowCount();
    if ($nr == 0) {
        echo "No Questions";
    }

    $_GLOBALS["FORUM_ANSWERS"] = [];
    while ($row = $q->fetch(PDO::FETCH_ASSOC)) {

        array_push($_GLOBALS["FORUM_ANSWERS"], array(
            "num_id" => $row["num_id"],
            "question_id" => $row["question_id"],
            "answer" => $row["answer"],
            "name" => $row["name"],
            "username" => $row["username"],
            "ip" => $row["ip"],
            "date" => $row["date"],
        ));
    }

    return $GLOBALS["FORUM_ANSWERS"];
}

SEPERATE FILE:

$answers = $forum->getAnswers();
echo count($answers);

if you while ($row = $q->fetch(PDO::FETCH_ASSOC)) { print_r($row); does that produce the arrays? — Rasclatt
– Rasclatt, Commented Dec 23, 2015 at 5:53
@objective_d noticed the problem. That being said, if you are trying to set to global try not to. Setting to global is not best practice, so-to-speak. — Rasclatt
– Rasclatt, Commented Dec 23, 2015 at 5:53

Rasclatt · Accepted Answer · 2015-12-23 05:56:14Z

4

You are assigning to $_GLOBALS and returning $GLOBAL.

You actually don't need to use a global array by the look of it - I would just assign the array to a variable (that you initialise in the function) and return that.

edited Dec 23, 2015 at 5:56

Rasclatt

12.5k3 gold badges28 silver badges33 bronze badges

answered Dec 23, 2015 at 5:53

frankle

1411 gold badge1 silver badge15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

David Yue Over a year ago

I'm returning $GLOBALS["FORUM_ANSWERS"];, am I not?

Rasclatt Over a year ago

Notice the underscore $_GLOBALS vs $GLOBALS

Collectives™ on Stack Overflow

Class Function does not return array properly

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related