Generate href value from a variable in ASP.Net MVC

Question

Controller action method-

public ActionResult Index()
{
   ViewBag.BaseUrl = "http://localhost:50926/";
   return View();
}

In ViewPage-

<a href="@ViewBag.BaseUrl/page.html">One</a>

This generates url as follows (notice the double slash at end)

"http://localhost:50926//page.html"

How to get rid of double slash? Please note that BaseUrl value can not be changed.

You can write some extension method which will remove all extra slashes and use it everywhere in the project. Do you need an example? — dimonser
– dimonser, Commented Dec 23, 2015 at 12:30

teo van kot · Accepted Answer · 2015-12-23 12:33:09Z

2

I suppose this is what you're looking for:

<a href="@(ViewBag.BaseUrl+"page.html")">One</a>

answered Dec 23, 2015 at 12:33

teo van kot

12.5k10 gold badges41 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

dimonser Over a year ago

I think it's not 100% safe. If ViewBag.BaseUrl doesn't contain ending slash then broken URL will be generated. This behavior is much more worse then double slashes

teo van kot Over a year ago

@dimonser I'm not sure what do you expect from this code. Every peace of code can broke on some conditions. But i don't think that you should write tons of code to avoid all errors. It's just not worth it.

dimonser Over a year ago

I think we should write safe code, especially in this case. Broken URLs generate angry users.

Pooria · Accepted Answer · 2015-12-23 12:41:20Z

1

try this in your view :

@{
     Uri baseUri = new Uri(ViewBag.BaseUrl);
     Uri myUri = new Uri(baseUri, "/page.html");
 }

and then use @myUri every place you want.

answered Dec 23, 2015 at 12:41

Pooria

15711 bronze badges

Comments

Martin · Accepted Answer · 2015-12-23 12:36:24Z

0

The solution is to avoid the extra slash before page.html. But you can't leave this text just near the variable. You must do that way :

<a href="@(ViewBag.BaseUrl)page.html">One</a>

In this case you will get "http://localhost:50926/page.html" without the unexpected double slash.

answered Dec 23, 2015 at 12:36

Martin

762 silver badges8 bronze badges

1 Comment

s.k.paul Over a year ago

I like your answer. Thank you.

Collectives™ on Stack Overflow

Generate href value from a variable in ASP.Net MVC

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related