UPDATE query inside a while loop php

Question

I need to grab images from an URL then change the URL into another. Here is my code for that. But it is not working as I expected. It is do change only one image. Others won't.

Here is my code,

<?php

include_once('db-conn.php');

$query = "SELECT my_image_url AS image FROM my_image";
$result = mysqli_query($mysqli, $query) or trigger_error("Query Failed! SQL: $query - Error: ". mysqli_error($mysqli), E_USER_ERROR);

if($result) {
    while($row = mysqli_fetch_assoc($result)) {
        $img_url = $row['image'];
        $content = file_get_contents($img_url);
        $img_name = basename($img_url);
        file_put_contents($img_name, $content);
        $query = "UPDATE `my_image` SET `my_image_url` = 'http://localhost/img/".$img_name."'";
        $result2 = mysqli_query($mysqli, $query) or trigger_error("Query Failed! SQL: $query - Error: ". mysqli_error($mysqli), E_USER_ERROR);
    }
}

?>

Do you mean it updates all images, or just one? If all you need a where clause. — chris85
– chris85, Commented Dec 28, 2015 at 5:27
Use where condition in your update query to update particulate row — Saty
– Saty, Commented Dec 28, 2015 at 5:27
You probably want SELECT my_image_url AS image, id FROM my_image then use the id to update the particular row. You also should use prepared statements, this could potentially get you injected. — chris85
– chris85, Commented Dec 28, 2015 at 5:28
Thanks for the comments, Yes I need a condition here. Now it is working fine after the condition (where clause). — WP Learner
– WP Learner, Commented Dec 28, 2015 at 6:04

jitendrapurohit · Accepted Answer · 2015-12-28 05:28:24Z

1

Change the query to the below one so as to update the column for the grabbed value

$query = "UPDATE `my_image` 
  SET `my_image_url` = 'http://localhost/img/".$img_name."' 
  WHERE `my_image_url` = {$img_url}";

answered Dec 28, 2015 at 5:28

jitendrapurohit

9,7032 gold badges31 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

WP Learner Over a year ago

I made a small change here, I used '".$img_url."' instead of {$img_url}. Now it is working correctly.

roullie · Accepted Answer · 2015-12-28 05:27:44Z

0

you should add a condition to your update query

$query = "UPDATE `my_image` SET `my_image_url` = 'http://localhost/img/".$img_name."' where (YOUR CONDITION HERE)";

answered Dec 28, 2015 at 5:27

roullie

2,82019 silver badges26 bronze badges

1 Comment

mustangDC Over a year ago

Explain why so.

Collectives™ on Stack Overflow

UPDATE query inside a while loop php

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related