javascript not pushing into array

Question

I am looping round a json object and getting an item within the object which holds a comma delimited string, I then split this string and check if its within the array and if not it should push it into the array. The problem is, it never pushes into the array

for (var item = 0; item < rules.length; item++) {
    //we now need to split the item by its delimiter which is a comma ','
    var treeSplit = rules[item].tree.split(',');

    if (treeSplit.length - 1 != childCount) {
        if (isInArray(treeSplit[childCount], aliasGroup)) {
            aliasGroup.push(treeSplit[childCount]);
        }
    } else {
        //do something
    }

This is my isInArray function it takes a value and the array

function isInArray(value, array) {
    return array.indexOf(value) > -1;
}

Try console logging the treesplit variable to see if it has split the json object as you were expecting. It may be that the split isn't working as expected. — Vistari
– Vistari, Commented Jan 11, 2016 at 15:01
so I stuck a breakpoint in firebug on the isInArray line and it doesn't seem to want to go into the code inside that if statement — Johnathon64
– Johnathon64, Commented Jan 11, 2016 at 15:01
@Vistari It has split properly so I have a string hello,world it splits into an array held in treeSplit childCount is set to 0 — Johnathon64
– Johnathon64, Commented Jan 11, 2016 at 15:02
Ah your if statement is incorrect when you're checking if it's in the array. You should negate it using ! so that it will work as expected. — Vistari
– Vistari, Commented Jan 11, 2016 at 15:03

Paul · Accepted Answer · 2016-01-11 15:01:56Z

5

and if not it should push it into the array

You're missing the not. You're pushing it into the array only if it is already in the array. Add a logical not operator ( ! ) :

if ( ! isInArray(treeSplit[childCount], aliasGroup) ) {
    aliasGroup.push(treeSplit[childCount]);
}

answered Jan 11, 2016 at 15:01

Paul

142k28 gold badges285 silver badges272 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jorrex Over a year ago

You beat me to it. I just noticed it when I was copying the code for further inspection. +1'ed

Collectives™ on Stack Overflow

javascript not pushing into array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related