Function call after recursive function returns

Question

I am having a recursive function in some service class to remove some json elements and once they are removed I have to call the callbacks registered for the updates.

My Code -

    var trimTree = function(){
    removeScripts(tree.children).then(function(){
      angular.forEach(callbacks, function(callback){
        //console.log(callback);
        console.log("Calling callbacks");
        callback();
      });
    });
  }
  function removeScripts(nodes){
    for(i=0;i<nodes.length;i++){
      if(nodes[i].type == 'script'){
        return nodes.splice(i, 1);
      }else{
        return removeScripts(nodes[i]);
      }
    }
  }

But its giving me error as TypeError: Cannot read property 'then' of undefined

Thanks

removeScripts doesn't return a promise, so you can't use .then. you might need to use $q to create a promise docs.angularjs.org/api/ng/service/$q — Nitsan Baleli
– Nitsan Baleli, Commented Jan 12, 2016 at 10:20
@NitsanBaleli, Promise is not needed in sync operations... — Rayon
– Rayon, Commented Jan 12, 2016 at 10:21

Madara's Ghost · Accepted Answer · 2016-01-12 10:20:11Z

4

You're assuming removeScripts() returns a Promise, it does not. removeScripts() is sync, so just add statements after it normally.

answered Jan 12, 2016 at 10:20

Madara's Ghost

176k52 gold badges274 silver badges314 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

AddWeb Solution Pvt Ltd · Accepted Answer · 2016-01-12 10:42:22Z

-1

You can try:

function removeScripts(nodes){
  var deferred = $q.defer();
  for(i=0;i<nodes.length;i++){
    if(nodes[i].type == 'script'){
      deferred.resolve(nodes.splice(i, 1));
    }else{
      deferred.reject(removeScripts(nodes[i]));
    }
  }
  return deferred.promise;
}

You need to use Deferred API.

answered Jan 12, 2016 at 10:42

AddWeb Solution Pvt Ltd

21.8k5 gold badges30 silver badges61 bronze badges

Collectives™ on Stack Overflow

Function call after recursive function returns

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related