Php loop giving an extra HTML element in output

Question

<?php
$sun=mysql_query("SELECT * FROM `red_users` WHERE `role`='user' AND `userID` != '$userID' ORDER BY `id` DESC LIMIT 10 ") or die(mysql_error());

while($su[]=mysql_fetch_array($sun)){

}

for($i=0;$i<count($su);$i++){

    $sud=$su[$i]['userID'];
    $sname=$su[$i]['name'];
    $dop=$su[$i]['dp'];
    $sxx=$su[$i]['sex'];

    if($dop != ''){
        $sey=$dop;
    }

    if($dop =='' AND $sxx=='MALE'){
        $sey="../images/male.png";
    }

    if($dop =='' AND $sxx=='FEMALE'){
        $sey="../images/female.png";
    }
?>

<a href="profile.php?frnd=<?php echo $sud ?>">
    <div class="inbox-item">
        <div class="inbox-item-img"><img src="<?php echo $sey ?>" class="img-circle" alt=""></div>
        <p class="inbox-item-author"><?php echo $sname; ?></p>
    </div>
</a>
<?php } ?

In output an extra Html element (with no dynamic data) is displaying.
After the Real elements which are populated by mysql query an extra element is displaying which contain no data.

u_mulder · Accepted Answer · 2016-01-12 13:45:41Z

2

Instead of

while($su[]=mysql_fetch_array($sun)){

}

and further processing of $su

process every record in the same while:

while($su=mysql_fetch_array($sun)){
    // do stuff
}

Additional note by @mloureiro:

This because the while keeps running till it find a false value, so when the mysql_fetch_array doesn't have anything else to return, it will give false that will be passed to the $su[] array.

edited Jan 12, 2016 at 13:45

answered Jan 12, 2016 at 13:39

u_mulder

54.8k5 gold badges54 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

user4689071 Over a year ago

it will run the while loop over and over again.so the page will be slow

u_mulder Over a year ago

You will run one while loop instead of two loops. Are you sure page will be slow?

mloureiro Over a year ago

@MuhammedAsif that doesn't make sense, I'm not an expert in mysql methods, but using the while + for just looks redundant.

mloureiro Over a year ago

@MuhammedAsif can you test this answer please?

mloureiro Over a year ago

I think I understand the question of @MuhammedAsif, the thing is instead of having the statements inside the for, move them to the while

|

Collectives™ on Stack Overflow

Php loop giving an extra HTML element in output

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related