php loop for (count array)/times

Question

I have a function geturls() that returns $urls as array

$urls[1] $urls[2] .....$urls[44]

However I don't know count of $urls (sometimes 44 45 77 ....)

And I want to make a loop for many times (44 in this case but could change)

So here is my script

function geturls($xml){
//my function
}

$urls = geturls($xml);
$counti = count($urls);

for ($i = 1; $i <= $counti; $i++) {
$modifiedurl = modify($urls[$i]);
echo $modifiedurl;
}

Is there a better way to do this (I'm sure there is a better way without using count() )?

Ozan Kurt · Accepted Answer · 2016-01-20 17:37:05Z

1

You can walk through an arrays elements with the array map function.

$modifiedUrls = array_map('modify', $urls);

Just made a test about our answers.

<?php

$start = microtime(true);

$urls = range(1, 1000000);

function modify($url)
{
    return "modified_".$url;
}

$modified_urls = [];

foreach ($urls as $url) {
    $modified_urls[] = modify($url);
}

// $modified_urls = array_map('modify', $urls);

$end = microtime(true);

$time_elapsed_secs = $end - $start;

echo $time_elapsed_secs;

foreach: 0.202~ ms
array_map: 0.130~s ms

edited Jan 20, 2016 at 17:37

answered Jan 20, 2016 at 17:24

Ozan Kurt

3,8634 gold badges22 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

AK47 Over a year ago

Thank you Ozan, but which is better in term of memory your way or the way of BEn Pearl Kahan ?

Ozan Kurt Over a year ago

A foreach loop is always faster than map, but I always felt like it's a bit cleaner.

Ozan Kurt Over a year ago

False comment! Sorry about that. Updated answer.

Ben · Accepted Answer · 2016-01-20 17:24:39Z

0

Use foreach():

$modified_urls = []; //create new array for modified URLs

foreach($urls as $url){
    $modified_urls[] = modify($url); //modify this URL and add it to the array
}

print_r($modified_urls); //output the array

edited Jan 20, 2016 at 17:24

answered Jan 20, 2016 at 17:21

Ben

8,9519 gold badges48 silver badges82 bronze badges

2 Comments

AK47 Over a year ago

Thank you for this fast answer

AK47 Over a year ago

Please see answer by Ozan Kurt, which one do you think is better in term of memory ?

Collectives™ on Stack Overflow

php loop for (count array)/times

2 Answers 2

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related