Can't call function of another class using OOP

Question

I'm a bit rusty with php, I want to know how I can call the function login available in class2, inside class1. This is the example:

<?php

    require_once("property2.php");

class Class1 
{
      public function __construct()
      {
         $cls2 = new Class2()
      }

      public function method1()
      {
          $cls2->login() //cl2 is undefined 
      }

} ..

//this is the function

...
class Class2
{
     public function __construct()
     {

     }

     //This is the  function to call

     public function login()
     {
       //Some stuff
     }
} ...

Now PHPSTORM say that the variable cls2 is undefined. What I did wrong?

@u_mulder I tried in method1 as $this->cls2->login() but I get this error in the network tab: Undefined property: Class1::$cls2 in ... the line that I shown before — Sandokan
– Sandokan, Commented Jan 29, 2016 at 16:37

Community · Accepted Answer · 2017-05-23 11:51:35Z

3

When you are setting your variable youre not setting it as a class property. Define a private variable inside your class, and "set it and get it" using the $this keyword.

class Class1 {
    private $cls2;

    public function __construct() {
        $this->cls2 = new Class2();
    }

    public function method1() {
        $this->cls2->login();
    }
}

Another way to achieve this is to use Inheritance, where one class is considered a "parent" class. You would achieve this by using extends

class Class1 {
    public function __construct() {
        //Some stuff
    }

    public function login() {
        //Some stuff
    }
}


class Class2 extends Class1 {
    public function __construct() {
        parent::__construct();
    }

    public function method1() {
        $this->login();
    }
}

edited May 23, 2017 at 11:51

CommunityBot

11 silver badge

answered Jan 29, 2016 at 16:37

CodeGodie

12.2k6 gold badges40 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kevin Kopf · Accepted Answer · 2016-01-29 16:37:45Z

2

class Class1 
{
      public function __construct()
      {
         $cls2 = new Class2();
      }

      public function method1()
      {
          $cls2->login() //cl2 is undefined 
      }

}

When you create Class1 and call $cls2 = new Class2();, $cls2 exists only locally. You have to make it a class property:

class Class1 
{

    public $cls2;

    public function __construct()
    {
       $this->cls2 = new Class2();
    }

    public function method1()
    {
        $this->cls2->login();
    }

}

And then you'll be able to access it using $this keyword.

Also please watch for semicolons.

answered Jan 29, 2016 at 16:37

Kevin Kopf

14.3k15 gold badges57 silver badges69 bronze badges

1 Comment

Sandokan Over a year ago

Oh okay, I understood now. Thanks :)

Collectives™ on Stack Overflow

Can't call function of another class using OOP

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related