adding object properties with an if statement

Question

so I am trying to add a property to an object if it doesn't already exist in the Object

so my code basically works

Psudo: (if the property doent exist in the object already add it in)

 var names= ["james", "kate", "kara", "milly"];
var storage = {}; 
var testElement = arr.pop(); 
  if(typeof(storage.testElement==='undefined')){  
    storage.testElement = '1';                    
  }
  else{
    storage.testElement = storage.testElement + 1; 
  }
return console.log(storage);

like I said this is sort of working, the output I get from the console log is { testElement: "1"} Where it says 'testElement' i need that to be the same as the item that was "popped" off the end of the array so in this case the last item in the array is "milly" so i need the object to say { milly: 1 } or { milly: "1" } Can anyone tell me how to change it?

thanks for all the answers you guys are thye best!

LucyViolet
– LucyViolet

2016-01-31 08:36:41 +00:00
Commented Jan 31, 2016 at 8:36 — LucyViolet
– LucyViolet, Commented Jan 31, 2016 at 8:36

Nina Scholz · Accepted Answer · 2016-01-31 10:06:46Z

1

Please wrap your variable for the object access in []

storage[testElement]

and change the line to

if (typeof storage[testElement] === 'undefined') {

otherwise you get the typeof of the comparison.

var names= ["james", "kate", "kara", "milly"];
var storage = {}; 
var testElement = names.pop(); 
if (typeof storage[testElement] === 'undefined') {
    storage[testElement] = '1';                    
} else {
    storage[testElement] = storage[testElement] + 1; 
}
document.write('<pre>' + JSON.stringify(storage, 0, 4) + '</pre>');

edited Jan 31, 2016 at 10:06

answered Jan 31, 2016 at 8:25

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jaffer · Accepted Answer · 2016-01-31 08:33:20Z

0

it should be

if(storage[testElement] === undefined)

and the working code, using hasOwnProperty to check property available or not then use [] notation to add/modify the property

var names= ["james", "kate", "kara", "milly"];
var storage = {}; 
var testElement = names.pop(); 
if(!storage.hasOwnProperty(testElement)){  
    storage[testElement] = '1';                    
}
else{
    storage[testElement] = storage[testElement] + 1; 
}
return console.log(storage);

edited Jan 31, 2016 at 8:33

answered Jan 31, 2016 at 8:27

Jaffer

2,97819 silver badges29 bronze badges

Comments

Siva · Accepted Answer · 2016-01-31 08:49:43Z

0

Here is the fix to get result as you expect.

var names= ["james", "kate", "kara", "milly"];
var storage = {}; 
var testElement = names.pop(); 
  if(typeof storage[testElement] === 'undefined'){  
    storage[testElement] = '1';                    
  }
  else{
    storage[testElement] = storage[testElement] + 1; 
  }
console.log(storage);

edited Jan 31, 2016 at 8:49

answered Jan 31, 2016 at 8:28

Siva

2,81518 silver badges14 bronze badges

2 Comments

ComradeAndrew Over a year ago

Why you didn't change typeof(storage.testElement==='undefined') in if statement?

Siva Over a year ago

Yes, that needs to be changed.. It worked in the current case bcoz storage is empty.

Collectives™ on Stack Overflow

adding object properties with an if statement

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related