Continuing a while loop after breaking a nested for loop

Question

I'm looking for a more pythonic way to continue a while loop after meeting some criteria in a nested for loop. The very clunky code that has worked for me is:

tens = ['30','40','50','60','70','80','90','00']
z=0
while z==0:
    num = input('Please enter a number: ')
    z=1    
    for x in tens:
        if num[0]=='0' or x in num:
            print('That was an invalid selection, please try again.\n')
            z=0  # There has GOT to be a better way to do this!
            break
print(num+' works, Thank You!')

I can use try/except as answered in this question:

tens = ['30','40','50','60','70','80','90','00']
while True:
    num = input('Please enter a number: ')  
    try:
        for x in tens:
            if num[0]=='0' or x in num:
                print('That was an invalid selection, please try again.\n')
                raise StopIteration
    except:
        continue
    break
print(num+' works, Thank You!')

The challenges I'm facing are

a) continue the while loop (request a new input) when the if is satisfied (in other words, break the for loop and continue the while loop in the same step)

b) run the tens iterable from scratch with every new input tested.

Note: this problem relates to Reddit Challenge #246 Letter Splits

UPDATE: incorporating answer supplied by Håken Lid, code becomes

tens = ['30','40','50','60','70','80','90','00']
while True:
    num = input('Please enter a number: ')
    if num[0]=='0' or any(t in num for t in tens):
        print('That was an invalid selection, please try again.\n')
        continue
    break
print(num+' works, Thank You!')

I haven't solved the "break/continue from a nested for-loop" but substituting the loop with an any() function definitely worked for me.

grzgrzgrz3 · Accepted Answer · 2016-01-31 17:28:46Z

0

In most of the cases having nested loops is bad design.

Your functions always should be small as possible. Applying to that rule you will never break first rule of SOLID (Single responsible principle).

Your code may look like this:

tens = ['30','40','50','60','70','80','90','00']

def main():
    while 1:
        num = input('Please enter a number: ')
        if nested_test(num):
            print('That was an invalid selection, please try again.\n')
            break

def nested_test(num):
    for x in tens:
        if <some test>:
            return True

answered Jan 31, 2016 at 17:28

grzgrzgrz3

3502 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Michael Brothers Over a year ago

I agree. Turning the nested loop/conditional test into its own function object is probably the most readable option.

Håken Lid · Accepted Answer · 2016-01-31 16:59:30Z

0

Your for loop is not needed. Just use in keyword. But apart from that your use of break is fine.

tens = ['30','40','50','60','70','80','90','00']
while True:
    num = input('Please enter a number: ')
    if num in tens:
       break
    print('That was invalid selection, please try again.\n')
print(num+' works, Thank You!')

answered Jan 31, 2016 at 16:59

Håken Lid

23.2k10 gold badges58 silver badges73 bronze badges

3 Comments

Michael Brothers Over a year ago

Unfortunately this doesn't work. I'm trying to see if any of the two-digit combinations in tens exist in a larger integer input like 55530555.

Håken Lid Over a year ago

I see. In that case you can use if any(t in num for t in tens):

Håken Lid Over a year ago

Or use a regular expression. if re.search('[3-90]0', num):

Collectives™ on Stack Overflow

Continuing a while loop after breaking a nested for loop

2 Answers 2

1 Comment

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related