ASP.NET Core 1 Dependency Injection: Implementation type always null

Question

I have the following inside my ConfigureServices method in the Startup class. I am adding a singleton instance of ToastNotification which is an implementation of IToastNotification.

public void ConfigureServices(IServiceCollection services)
{
   services.AddInstance<IToastNotification>(new ToastNotification()
         {
         });
}

The problem is that when I watch the value of services while debugging at the end of this method, the implementation type of the IToastNotification service is null. Therefore, when I try to get the Toastnotification instance from the services collection in the controllers, it is always null.

This is how I am getting the Toastnotification using dependency injection

[FromServices]
private IToastNotification ToastNotification { get; set; }

What am I doing wrong?

Kévin Chalet · Accepted Answer · 2016-02-02 01:42:10Z

3

Don't use property injection, it has been removed and won't work in the future versions: https://github.com/aspnet/Announcements/issues/115.

Instead, consider using constructor dependency injection.

answered Feb 2, 2016 at 1:42

Kévin Chalet

42.3k8 gold badges130 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nabin Karki Thapa Over a year ago

Thank you. I did what you said. I guess I need to keep a close eye on all the breaking changes.

Thomas · Accepted Answer · 2016-02-02 02:21:07Z

0

Using constructor dependency injection, you can do thing like that:

// Register your service.
services.AddInstance<IToastNotification>(new ToastNotification());

And in your Controller:

public class HomeController : Controller
{
    private readonly IToastNotification _toastNotification;

    public HomeController(IToastNotification toastNotification)
    {
        _toastNotification = toastNotification;
    }

    ...
}

answered Feb 2, 2016 at 2:21

Thomas

30.5k6 gold badges99 silver badges143 bronze badges

Collectives™ on Stack Overflow

ASP.NET Core 1 Dependency Injection: Implementation type always null

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related