PHP array empty after pushing in foreach

Question

I am pushing values inside an array in foreach loop and the values seem to be added in the array so the problem is not in the pushing condition. However when I go through that array again, it is empty.

Can please anyone explain to me, why this code

foreach ($allItems as $pair) {
    for ($i = 0; $i < count($keywords); $i++) {
        if ($this->itemInArray($pair["item"], $items2D[$i])) {
            array_push($pair["keywords"], $keywords[$i]->getWord());
        }
    }
    $this->log("Keywords count inside loop: ".count($pair["keywords"]));
}

foreach ($allItems as $pair) {
    $this->log("Keywords count outside loop: ".count($pair["keywords"]));
}

Outputs this:

Keywords count inside loop: 3
Keywords count inside loop: 1
Keywords count inside loop: 1
Keywords count inside loop: 1
Keywords count outside loop: 0
Keywords count outside loop: 0
Keywords count outside loop: 0
Keywords count outside loop: 0

what am I doing wrong and how to fix it?

Zbynek Vyskovsky - kvr000 · Accepted Answer · 2016-02-02 14:07:21Z

4

By this you get a copy of the array and modify the copy ($pair):

foreach ($allItems as $pair) {

You need to modify to get reference to $pair (note the &):

foreach ($allItems as &$pair) {

answered Feb 2, 2016 at 14:07

Zbynek Vyskovsky - kvr000

19.1k3 gold badges41 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Buck Mathers · Accepted Answer · 2016-02-02 14:16:27Z

0

You can not iterate through an array with foreach() while pushing items in to it.

Try pushing to a new variable in the foreach statement:

array_push($newPair,$keywords[$i]->getWord());

answered Feb 2, 2016 at 14:16

Buck Mathers

12 bronze badges

Collectives™ on Stack Overflow

PHP array empty after pushing in foreach

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related