Delete specific row in database table and generatet html table

Question

This is my delete page :

<?php 
require('includes/config.php'); 

    $id = $_GET['ID'];
    $pdoConnect = new PDO($db);
    $query='DELETE * FROM studentraspored WHERE ID = "' . $id . '" ';
    $pdoResult = $db->prepare($query);

    $pdoExec = $pdoResult->execute($query);

    header('location:index.php');
?>

This is generated table in my “memberpage.php”:

if (count($rows)){
    foreach ($rows as $row) {       
        $_SESSION['row'] = $rows;
        $id = floatval($row['ID']);
        echo "<tr>" .
            '<form action="delete_raspored.php" method="post">'.
            "<td>" . $row["ID"] . "</td>" .
            "<td>" . $row["den"] . "</td>" .
            "<td>" . $row["chas"] . "</td>" .
            "<td>" . $row["predmet"] . "</td>" .
            "<td>" . $row["profesor"] . "</td>" .               
            "<td>" . $row["prostorija"] . "</td>" .
            "<td>" . $row["tip"] . "</td>" .
            '<td><input type="submit" id="' . $id . '" value="Delete" ></td>'.
            "</form>".
            "</tr>"

This not working properly. I don't understand why maybe something i missed with floatval

Maybe. You should be using an integer for your ID, rather than a float. You may not be getting a 1/1 match when your run your query. — durbnpoisn
– durbnpoisn, Commented Feb 2, 2016 at 14:44
Hmm might have to update answer, what is $db and where is it defined? — chris85
– chris85, Commented Feb 2, 2016 at 15:02
Okay, that's what I though, so you don't need $pdoConnect = new PDO($db);, I'll update answer. — chris85
– chris85, Commented Feb 2, 2016 at 15:11

chris85 · Accepted Answer · 2016-02-02 15:12:00Z

1

Start by trying this:

<?php 
require('includes/config.php'); 
$id = $_GET['ID'];
$query='DELETE FROM studentraspored WHERE ID = ?';
$pdoResult = $db->prepare($query);
$pdoResult->execute(array($id));
header('location:index.php');
exit();

Note the placeholder in place of the actual value, this will prevent SQL injections. The value is passed in in the execute, or you could bind it (http://php.net/manual/en/pdostatement.bindparam.php). http://php.net/manual/en/pdo.prepared-statements.php

The delete syntax was also off, delete deletes a whole row not specific columns, http://dev.mysql.com/doc/refman/5.7/en/delete.html.

In your form I also don't see an element named ID so that could be another issue and your form is submitting via POST, not GET.

edited Feb 2, 2016 at 15:12

answered Feb 2, 2016 at 14:50

chris85

23.9k7 gold badges36 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Delete specific row in database table and generatet html table

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related