Handle Multiple action with same name in MVC

Question

In my project there is an action

public ActionResult Lead(int leadId)
{
    return View();
}

and in the View an ActionLink was created like this

@Html.ActionLink("Old Link", "Lead", "Home", new { leadId = 7 }, null)

But after some time, to make clean URL, I have changed the name of parameter of that action

public ActionResult Lead(int id)
{
    return View();
}

And ActionLink change accordingly

@Html.ActionLink("New Link", "Lead", "Home", new { id = 5 }, null)

But old link was shared in multiple social network sites. Whenever anyone clicks on that old link, he is redirect to the page www.xyx.com/Home/Lead?leadId=7

But now in my application, no such URL exists.

To handle this problem, I was thinking of overloading, but MVC action doesn't support overloading.

I have created another Action with same name with extra parameter, and redirect to new action, but it doesn't work.

public ActionResult Lead(int leadId, int extra=0)
{
    return RedirectToAction("Lead", "Home", new { id = leadId });
}

I have found one link to handle such situation, but It is not working in my case.

ASP.NET MVC ambiguous action methods

Darin Dimitrov · Accepted Answer · 2016-02-08 16:56:27Z

2

One possibility to handle this would be to write a custom route:

public class MyRoute : Route
{
    public MyRoute() : base(
        "Home/Lead/{id}",
        new RouteValueDictionary(new
        {
            controller = "Home",
            action = "Lead",
            id = UrlParameter.Optional,
        }),
        new MvcRouteHandler()
    )
    {
    }

    public override RouteData GetRouteData(HttpContextBase httpContext)
    {
        var rd = base.GetRouteData(httpContext);
        if (rd == null)
        {
            return null;
        }

        var leadId = httpContext.Request.QueryString["leadid"];
        if (!string.IsNullOrEmpty(leadId))
        {
            rd.Values["id"] = leadId;
        }

        return rd;
    }
}

that you will register before the default one:

public static void RegisterRoutes(RouteCollection routes)
{
    routes.IgnoreRoute("{resource}.axd/{*pathInfo}");

    routes.Add(new MyRoute());

    routes.MapRoute(
        name: "Default",
        url: "{controller}/{action}/{id}",
        defaults: new { controller = "Home", action = "Index", id = UrlParameter.Optional }
    );
}

and now you could only have a single action:

public ActionResult Lead(int id)
{
    return View();
}

Now both the following urls will work as expected:

www.xyx.com/Home/Lead/7
www.xyx.com/Home/Lead?leadId=7

edited Feb 8, 2016 at 16:56

answered Feb 8, 2016 at 7:39

Darin Dimitrov

1.0m276 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mir Gulam Sarwar Over a year ago

Could you clarify , why his RedirectToAction not working?

Amit Kumar Over a year ago

@darin: It is now working . But the problem again same. Now It start creating query string for parameter id http://www.xyx.com/Home/Lead?id=5

Darin Dimitrov Over a year ago

When calling the base constructor you could try "Home/Lead/{id}" instead of "Home/Lead". I have updated my answer to reflect this.

Collectives™ on Stack Overflow

Handle Multiple action with same name in MVC

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related