angularJS service model avoid duplicates

Question

Just a quick question how to avoid duplication of code when doing a http post and put of the same form.

say:

// Post new form
function postForm(form){
    var data = {
        name: form.name
        lastName: form.lastName
    }

    return api.post('jobs', undefined, JSON.stringify(data), 'application/json');
}

// Put save/edit existing (data)
function putForm(form){
    var data = {
        name: form.name
        lastName: form.lastName
    }

    return api.put('jobs', undefined, JSON.stringify(data), 'application/json');
}

My attempt, but then I don't have access to function form parameter.

var data = {
    name: name
    lastName: lastName
}

// Post new form
function postForm(form){
    return api.post('jobs', undefined, JSON.stringify(data), 'application/json');
}

// Put save edit form
function postForm(form){
    return api.put('jobs', undefined, JSON.stringify(data), 'application/json');
}

Not sure if I'm making sense here but hopefully someone will get what I'm trying to do. Basically I don't want to duplicate the var data when calling api post or put.

Justus Romijn · Accepted Answer · 2016-02-09 15:13:41Z

2

Maybe use a normalizing helper function?

// Post new form
function postForm(form){
    return $http.post('api', extractData(form));
}

// Put save/edit existing (data)
function putForm(form){
    return $http.put('api', extractData(form));
}


// private helper    
function extractData(data){
    return JSON.stringify({
        name: data.name,
        lastName: data.lastName
    });
}

Of course you can add some configuration to the normalizer if you need subtle changes per implementation.

edited Feb 9, 2016 at 15:13

answered Feb 9, 2016 at 8:47

Justus Romijn

16.1k5 gold badges54 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

MrNew Over a year ago

See my update above, atm that's how I'm sending the objs. Seems to work fine, I wrapped the extractData in JSON.stringify because it was giving me a 400 err. But which is better to use this approach or using JSON.parse(JSON.stringify(form)). Objs are coming from the back-end

Justus Romijn Over a year ago

Not sure why you would stringify and then parse, but if you need the JSON.parse result, just do that in your helper function. See updated example.

Andrew Shepherd · Accepted Answer · 2016-02-09 09:38:51Z

0

You have two function implementations, and the only thing that's different between the two is the http function used.

In javascript, functions are first class objects, so you can pass the http function as a parameter..

function send(form, httpMethod) {
   var data = {
     name: form.name
     lastName: form.lastName
   };
   return httpMethod.apply($http, [
     'jobs',
     undefined,
     JSON.stringify(data),
     'application/json'
   ]);
 }

 // Post new form
 function postForm(form) {
   send(form, $http.post);
 }

 // Put save edit form
 function putForm(form) {
   send(form, $http.put);
 }

It is necessary to invoke the method through apply, rather than simply invoking httpMethod('api', data);, because the methods may rely on fields hanging off the this pointer.

edited Feb 9, 2016 at 9:38

answered Feb 9, 2016 at 8:55

Andrew Shepherd

45.5k33 gold badges148 silver badges212 bronze badges

Comments

Alex Szabo · Accepted Answer · 2016-03-03 14:51:34Z

0

Haven't tested it, but this might work for you

function postForm(form, method){

    var data = {
        name: form.name
        lastName: form.lastName
    };

    return $http({
                  url: 'api', 
                  method: method,
                  data: data
                  });
}

edited Mar 3, 2016 at 14:51

answered Feb 9, 2016 at 8:52

Alex Szabo

3,2842 gold badges21 silver badges33 bronze badges

Collectives™ on Stack Overflow

angularJS service model avoid duplicates

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related