need a more efficient way of working with object data source in .net

Question

I am writting a website using .net in some of my pages I need to use datagrid for showing some datas and for binding my data to datagrid I use object datasource something like below :

//this is 
public class userData
{
    private long userid = 0;
    private string username = null;
    private long amounts = 0;
    private DateTime registerdate;

    public long Userid
    {
        get { return userid; }
        set { userid = value; }
    }

    public string Username
    {
        get { return username; }
        set { username = value; }
    }

    public long Amounts
    {
        get { return amounts; }
        set { amounts = value; }

    }

    public DateTime Registerdate
    {
        get { return registerdate; }
        set
        { registerdate = value;}

    }

    }

//my businesshelper class

public class BusinessHelper
{
    public BusinessHelper()
    {
        //
        // TODO: Add constructor logic here
        //
    }


    public ICollection GetusersAmount()
    {
        ArrayList list = new ArrayList();
        DataSet1TableAdapters.userTableAdapter usert = new DataSet1TableAdapters.userTableAdapter();
        DataSet1.userDataTable ud = usert.GetData();


        foreach(DataSet1.userRow R in ud)
        {
            userData user = new userData();
            user.Amounts = R.Amount;
            user.Registerdate = R.registerdate;
            user.Userid = R.userID;
            user.Username = R.username ;
            list.Add(user);

        }
        return list;
    }
}

and then in my apsx file I put an objectdatasource and bind the select statement to the GetUsersAmount() and then bind obejctdatasource to my datagrid

but I think the way I've chosen is not efficient I just want to hear about your way of doing such these things.

regards.

Henk Holterman · Accepted Answer · 2010-08-20 12:06:03Z

2

You can start by using auto properties:

public class userData
{
  //  private long userid = 0;

    public long Userid    { get; set;   }

    ....
}

And, assuming you want to keep the TableAdapter:

// untested
DataSet1.userDataTable ud = usert.GetData();

var list = from r in ud.Rows.AsEnumerable()
           select new userData() { Userid = r.userID, Username = r.username }

return list; // maybe list.ToList()

Aa an aside, I would suggest taking a good look at your naming conventions, those lower case class names confused me quite a bit.

edited Aug 20, 2010 at 12:06

answered Aug 20, 2010 at 11:57

Henk Holterman

276k33 gold badges353 silver badges540 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

VinayC Over a year ago

I don't know what "austin powers" meant by efficient. So just want to nitpick that above code is efficient from coding efforts perspective (and not otherwise).

Vahid Hashemi Over a year ago

actually I want to fill up the datagrid in a custom way and manipulate some datas like converting Georgian calendar date to solar calendar date and so on ... and I thought to use ODS(Obejct Data Source) but I really don't know my way is correct or not? in aspect of paging and editing can I rely on ODS when its bind to datagrid?

Henk Holterman Over a year ago

@VinaYc, the OP wants to feed it to a Datagrid. Any optimization here is going to be so tiny in comparison. I take efficiency as "easy and clear to write/maintain"

VinayC · Accepted Answer · 2010-08-20 12:12:58Z

1

I don't think that you are doing anything wrong (at the most, as suggested by other poster, you can use DataReader instead of data set). The class userData is typically called DTO (data transfer object) or entity class. You have other choices of DTO as well as - for example, you can use typed data tables or generic data sets. Custom classes are the most flexible choice but of course needs most efforts - because you have to hand-code them and write logic to fill/save them. There are frameworks (OR Mapper) to reduce these mundane efforts and generate data access code automatically. Example of such tools would be Entity Framework (ADO.NET Entity Model), Linq To Sql, NHibernate etc.

answered Aug 20, 2010 at 12:12

VinayC

49.6k7 gold badges64 silver badges74 bronze badges

Comments

Dan Scott · Accepted Answer · 2010-08-20 11:57:50Z

0

I wouldn't use a dataset to populate your list of business objects, but would use a SqlDataReader or something along those lines. Datasets have much more overhead than DataReaders.

I also would use a Collection (or something based on IEnumerable) to return the list of business objects back. There is probably a cost involved in casting to and from an ArrayList.

You may also want to implement some paging support into your method, unless your datagrid displays every record at once.

answered Aug 20, 2010 at 11:57

Dan Scott

1371 silver badge9 bronze badges

Collectives™ on Stack Overflow

need a more efficient way of working with object data source in .net

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related