PHP Illegal String Offset Warning

Question

Disclaimer: I'm not a PHP programmer. I don't really consider myself a programmer at all. I was just unfortunate enough to inherit some code that doesn't work.

So I have this code. I believe it was written for PHP4, but we're using PHP5.

// Retrieve project list
$project = new CProject();
$proj = $project->getAllowedRecords( $AppUI->user_id, 'project_id, project_name');
foreach ( $proj as $k => $p ) {
    $project_select_list[$k] = $p['project_name'];
}

This is supposed to populate a pick list based on the user's role, but it doesn't work. I get the "illegal string offset" warning on the line inside of the foreach loop. I think understand what it's trying to do, but I don't enough about PHP to fix it. I did a vardump on $proj and it returned this.

array(5) { 
  [1]=> string(4) "Roof" 
  [2]=> string(4) "Wall" 
  [3]=> string(4) "Yard" 
  [4]=> string(7) "Kitchen" 
  [5]=> string(8) "Bathroom" 
}

Anyone got any hints on how to fix it? Thanks.

Without context of the CProject object, it's kind of hard to pinpoint what exactly is going on. — Derek Pollard
– Derek Pollard, Commented Feb 10, 2016 at 17:34
You don't have keys named project_name in $proj, so $p['project_name'] is invalid. Just do $project_select_list[$k] = $p; — Sean
– Sean, Commented Feb 10, 2016 at 17:35

gen_Eric · Accepted Answer · 2016-02-10 17:36:17Z

4

This seems to be produced by this:

 $p['project_name'];

If $p variable is a string (as the var_dump() said), you don't have an array to access nowhere. The most probably solution is this:

foreach ( $proj as $k => $p ) {
    $project_select_list[$k] = $p;
}

edited Feb 10, 2016 at 17:36

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

answered Feb 10, 2016 at 17:35

Marcos Pérez Gude

22.2k4 gold badges41 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Marcos Pérez Gude Over a year ago

Thank you @RocketHazmat for notice the bracket outside :)

mckinnej Over a year ago

Getting rid of ['project_name'] and just using $p did the trick as Sean and Rocket both suggested. Thanks!

Collectives™ on Stack Overflow

PHP Illegal String Offset Warning

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related