php merge/push array into other array

Question

I just cannot get this fairly simple thing right.

I create many arrays like this:

foreach( $terms as $term ){
  $single_attribute = array();
  $archive_link = get_term_link( $term->slug, $attribute['name'] );
  array_push( $single_attribute, $term->name, $archive_link);
}

Which generates many arrays like following:

Array ( [0] => attribute_1  [1] => http://domain.com/products/attribute_1/ )

I need to push/merge (not sure about correct naming here) each of these arrays into one big array, so that the final result would be liek following:

Array ( [0] => Array ( [0] => attribute_1  [1] => http://domain.com/products/attribute_1 ) [1] => Array ( [0] => attribute_2 [1] => http://domain.com/products/attribute_2 ))

Sougata Bose · Accepted Answer · 2016-02-12 09:18:45Z

2

$single_attribute is getting defined in every iteration with empty array. Define the array outside the loop.

$single_attribute = array();

foreach( $terms as $term ){

       $archive_link = get_term_link( $term->slug, $attribute['name'] );

       array_push( $single_attribute, array($term->name, $archive_link) );                                                                                      
}

edited Feb 12, 2016 at 9:18

answered Feb 12, 2016 at 9:16

Sougata Bose

31.8k8 gold badges52 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

isnisn · Accepted Answer · 2016-02-12 09:31:26Z

1

A more elegant solution without using array_push would be:

    foreach( $terms as $term ){
      $archive_link = get_term_link( $term->slug, $attribute['name'] );
      $single_attribute[] = array($term->name, $archive_link) );
    }

$final_array[] = $single_attribute;

Which would give you your expected output.

answered Feb 12, 2016 at 9:31

isnisn

2541 silver badge7 bronze badges

Comments

simon · Accepted Answer · 2016-02-12 09:32:25Z

0

According to the documentation, you shouldn't use array_push() for this task:

Note: If you use array_push() to add one element to the array it's better to use $array[] = because in that way there is no overhead of calling a function.

Do something like this:

$attributes = array();
foreach($terms as $term) {
    $archive_link = get_term_link($term->slug, $attribute['name']);
    $attributes[] = array($term->name, $archive_link);
}

answered Feb 12, 2016 at 9:32

simon

2,9661 gold badge20 silver badges22 bronze badges

Collectives™ on Stack Overflow

php merge/push array into other array

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related